Take obsprep config info out of dict and into config yaml #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewEichmann-NOAA
requested review from
ShastriPaturi,
guillaumevernieres and
apchoiCMD
apchoiCMD
previously approved these changes
Jan 18, 2024
ShastriPaturi
previously approved these changes
Jan 18, 2024
AndrewEichmann-NOAA
dismissed stale reviews from apchoiCMD and ShastriPaturi
via
72b9157
guillaumevernieres
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
I forgot about this PR @AndrewEichmann-NOAA , sorry! Looks good.
|
Could you fix the code norm @AndrewEichmann-NOAA ? |
removing lines for coding style
|
@guillaumevernieres done |
guillaumevernieres
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left over observer info for obs prep was still in a dict in ush/soca/prep_marine_obs.py, now in
parm/soca/obsprep/obsprep_config.yaml with supplementary info
Resolves #781