Faster process for Marine Analysis Vrfy Task #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apchoiCMD
requested review from
guillaumevernieres,
ShastriPaturi and
AndrewEichmann-NOAA
There was a problem hiding this comment.
Thanks for looking into this @apchoiCMD . I'm sure there's a more OO way of solving this problem, but good enough for now!
I have a few minor comments, but it also needs to be profiled properly before we merge.
guillaumevernieres
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks @apchoiCMD , looks good. I assume you checked the figures and it all looks OK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
statePlotter(config)concurrentlyProfiling shows that the process of
vrfytask is reduced to around ~240 to 250 sec