-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GRIB2 template 4.46 for RRFS use. #115
Adding GRIB2 template 4.46 for RRFS use. #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some test code for this.
@edwardhartnett Both @EricJames-NOAA and I can run UPP to test. But you have to install a new version of g2ptml module (1.10.3?) under the spack-stack. |
Actually I mean test code within this repo. See https://github.com/NOAA-EMC/NCEPLIBS-g2tmpl/blob/develop/tests/test_g2tmpl_pdt4_11.F90 for example. |
@edwardhartnett I have no knowledge to test that kind of code. |
OK, I will add a test... |
@WenMeng-NOAA and @EricJames-NOAA take a look at #125 to see how we can easily write an automated test for a subroutine such as this. The test simply sets all the required values, then calls the subroutine, then checks that the results match an expected result. This sort of testing, though simple, has been proven again and again to be far more time efficient and useful than manual testing. In a manual testing cycle, you are unlikely to try every different template supported by NCEPLIBS-g2tmpl, but automated testing does exactly that, every time a pull request is submitted. |
Adding template 4.46 so that it can be used in UPP for some needed RRFS output.
Part of #118