Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doxygen and some code warnings #120

Merged
merged 11 commits into from
Apr 16, 2024
Merged

fix doxygen and some code warnings #120

Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c76af88
fix doxygen
edwardhartnett Apr 16, 2024
d11d78d
fixed some warnings
edwardhartnett Apr 16, 2024
3fc55fc
more warning fixes
edwardhartnett Apr 16, 2024
5c8c29d
more warning fixes
edwardhartnett Apr 16, 2024
817fa13
more warnings fixed
edwardhartnett Apr 16, 2024
4eb3c3d
fixed more warnings
edwardhartnett Apr 16, 2024
c497021
fixed more warnings
edwardhartnett Apr 16, 2024
b51d1fe
turned on -Werror
edwardhartnett Apr 16, 2024
3b5919a
fixed warning
edwardhartnett Apr 16, 2024
6ce56f7
fixed warning
edwardhartnett Apr 16, 2024
5893397
fixed warning
edwardhartnett Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 42 additions & 38 deletions src/grib2_all_tables_module.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ module grib2_all_tables_module
data table1_4(8) /type_of_data('proc_rad_obs',7)/
data table1_4(9) /type_of_data('event_prob',8)/
data table1_4(10) /type_of_data('missing',255)/
data table1_4(11) /type_of_data('experimental_products',192)/
data table1_4(11) /type_of_data('experimental_product',192)/
!
!
type type_of_gen_proc
Expand Down Expand Up @@ -1172,7 +1172,7 @@ module grib2_all_tables_module
data on388_tablea(112) /gen_proc('extra_trop_storm_surge_pacific',17)/
data on388_tablea(113) /gen_proc('prob_extra_trop_storm_surge',18)/
data on388_tablea(114) /gen_proc('linmit_fine_mesh_anal',19)/
data on388_tablea(115) /gen_proc('extra_trop_storm_surge_micronesia',20)/
data on388_tablea(115) /gen_proc('extra_trop_storm_surge_microne',20)/
data on388_tablea(116) /gen_proc('hur_weather_res_and_fcst',71)/
data on388_tablea(117) /gen_proc('hur_non-hydro_multi',72)/
!
Expand All @@ -1188,7 +1188,7 @@ module grib2_all_tables_module
!
data on388_tablea(120) /gen_proc('extra_trop_storm_surge_atl_3d',21)/
data on388_tablea(121) /gen_proc('extra_trop_storm_surge_pac_3d',22)/
data on388_tablea(122) /gen_proc('extra_trop_storm_surge_micro_3d',23)/
data on388_tablea(122) /gen_proc('extra_trop_storm_surge_micro_3',23)/

contains
!
Expand Down Expand Up @@ -1394,13 +1394,14 @@ end subroutine get_g2_unitoftimerange
!>
!> @param[in] key - GRIB2 character short key for fixed surface types from Table 4.5
!> @param[out] value - corresponding GRIB2 value from Table 4.5
!> @param[out] ierr - error messages
!> @param[out] ierr - 0 for success, 9 if key not found
!>
!> @author V. Krishna Kumar ORG: W/NP12 @date 2009-12-10
!> @author V. Krishna Kumar ORG: W/NP12 @date 2009-12-10
subroutine get_g2_fixedsurfacetypes(key, value, ierr)
character(len=*) :: key
integer :: value, n, ierr
!
ierr = 0
do n=1, MAXFIXEDSURFACETYPES
if (trim(table4_5(n)%fixedsurfacetypeskey).eq.trim(key)) then
value=table4_5(n)%fixedsurfacetypesval
Expand All @@ -1411,7 +1412,7 @@ subroutine get_g2_fixedsurfacetypes(key, value, ierr)
value=table4_5(66)%fixedsurfacetypesval
! print *, 'get_g2_fixedsurfacetypes key: ', trim(key), value, &
! ' not found in table 4.5'
! ierr=9
ierr=9
return
end subroutine get_g2_fixedsurfacetypes
!>
Expand Down Expand Up @@ -2034,9 +2035,9 @@ subroutine g2sec4_temp44(icatg, iparm, aer_type, typ_intvl_size, &
call get_g2_typeofintervals(typ_intvl_size, value, ierr)
ipdstmpl44(4) = value
ipdstmpl44(5) = scale_fac1_size
ipdstmpl44(6) = scale_val1_size
ipdstmpl44(6) = int(scale_val1_size)
ipdstmpl44(7) = scale_fac2_size
ipdstmpl44(8) = scale_val2_size
ipdstmpl44(8) = int(scale_val2_size)
!
call get_g2_typeofgenproc(typ_gen_proc_key, value, ierr)
ipdstmpl44(9) = value
Expand Down Expand Up @@ -2066,11 +2067,14 @@ subroutine g2sec4_temp44(icatg, iparm, aer_type, typ_intvl_size, &
!
end subroutine g2sec4_temp44
!>
!> This subroutine returns the Grib2 Section 4 Template 4.0 list for given keys
!> PDT 4.46 - Average, accumulation, and/or extreme values or other
!> statistically processed values at a horizontal level
!> or in a horizontal layer in a continuous or
!> non-continuous time interval for aerosol.
!> Returns the GRIB2 Section 4 Template 4.0 list.
!>
!> <pre>
!> PDT 4.46 - Average, accumulation, and/or extreme values or other
!> statistically processed values at a horizontal level
!> or in a horizontal layer in a continuous or
!> non-continuous time interval for aerosol.
!> </pre>
!>
!> @param[in] icatg - Parameter category (see Code table 4.1)
!> @param[in] iparm - Parameter number (see Code table 4.2)
Expand Down Expand Up @@ -2098,28 +2102,33 @@ end subroutine g2sec4_temp44
!> @param[in] hour_intvl - Hour Time of end of overall time interval
!> @param[in] min_intvl - Minute Time of end of overall time interval
!> @param[in] sec_intvl - Second Time of end of overall time interval
!> @param[in] num_time_range - n number of time ranges specifications describing
!> the time intervals used to calculate the
!> statistically-processed field
!> @param[in] stat_miss_val - Total number of data values missing in statistical process
!> Specification of the outermost (or only) time range over
!> which statistical processing is done
!> @param[in] type_of_stat_proc - Statistical process used to calculate the processed
!> field from the field at each time increment during the
!> time range (see Code Table 4.10)
!> @param[in] type_of_time_inc - Type of time increment between successive fields
!> used in the statistical processing (see Code Table 4.11)
!> @param[in] stat_unit_time_key - Indicator of unit of time for time range over which
!> statistical processing is done (see Code Table 4.4)
!> @param[in] leng_time_range_stat - Length of the time range over which statistical processing
!> is done, in units defined by the previous octet
!> @param[in] stat_unit_time_key_succ - Indicator of unit of time for the increment between the
!> successive fields used (see Code table 4.4)
!> @param[in] time_inc_betwn_succ_fld - Time increment between successive fields,
!> in units defined by the previous octet (see Notes 3 & 4)
!> @param[in] num_time_range - n number of time ranges
!> specifications describing the time intervals used to calculate
!> the statistically-processed field
!> @param[in] stat_miss_val - Total number of data values missing in
!> statistical process Specification of the outermost (or only) time
!> range over which statistical processing is done
!> @param[in] type_of_stat_proc - Statistical process used to
!> calculate the processed field from the field at each time
!> increment during the time range (see Code Table 4.10)
!> @param[in] type_of_time_inc - Type of time increment between
!> successive fields used in the statistical processing (see Code
!> Table 4.11)
!> @param[in] stat_unit_time_key - Indicator of unit of time for
!> time range over which statistical processing is done (see Code
!> Table 4.4)
!> @param[in] leng_time_range_stat - Length of the time range over
!> which statistical processing is done, in units defined by the
!> previous octet
!> @param[in] stat_unit_time_key_succ - Indicator of unit of time
!> for the increment between the successive fields used (see Code
!> table 4.4)
!> @param[in] time_inc_betwn_succ_fld - Time increment between
!> successive fields, in units defined by the previous octet (see
!> Notes 3 & 4)
!> @param[out] ipdstmpl46 - GRIB2 PDS Template 4.46 listing
!>
!> @author E. JAMES ORG: NOAA/GSL @date 2024-04-02
!> @author E. JAMES, NOAA/GSL @date 2024-04-02
subroutine g2sec4_temp46(icatg, iparm, aer_type, typ_intvl_size, &
scale_fac1_size, scale_val1_size, scale_fac2_size, &
scale_val2_size, typ_gen_proc_key, gen_proc_or_mod_key, &
Expand Down Expand Up @@ -2409,7 +2418,6 @@ subroutine g2sec5_temp0(dec_scale_fac, bin_scale_fac, tlnumbits, ifield5)
integer(4), intent(in) :: bin_scale_fac, dec_scale_fac, tlnumbits
integer(4), intent(out) :: ifield5(5)
! character(len=50) :: type_of_field
integer(4) :: value, ierr
!
ifield5(1) = 0 ! Any value. Will be later overwritten
ifield5(2) = bin_scale_fac
Expand Down Expand Up @@ -2439,8 +2447,6 @@ subroutine g2sec5_temp2(dec_scale_fac, bin_scale_fac, ifield5)
integer(4), intent(inout) :: ifield5(16)
integer(4), intent(in) :: dec_scale_fac, bin_scale_fac
!
integer(4) :: value, ierr
!
ifield5=0
ifield5(1) = 0 ! Any value. Will be later overwritten
ifield5(2) = bin_scale_fac
Expand Down Expand Up @@ -2519,8 +2525,6 @@ subroutine g2sec5_temp40(dec_scale_fac, bin_scale_fac, tlnumbits,
!--- local variable
integer(4) :: value, ierr
integer, parameter :: MAX_NUMBIT=16
integer ibm
integer, allocatable :: mg(:)
!
ifield5(1) = 0 ! Any value. Will be later overwritten
ifield5(2) = bin_scale_fac
Expand Down
Loading