Add data ocean support and add support for reading modelio:: attribute group ... #106
Conversation
…to feature/hafs_couplehycom.
…NUOPC for jet/orion/wcoss
…re/hafs_couplehycom
…re/hafs_couplehycom
Merge feature/hafs_couplehycom branch back into support/HAFS branch Preparations for external PIO (Ufuk) *Added CPP -DPIO to wrap calls to pio library *component_CDEPS.mk added to configure CDEPS build *component_CDEPS_DATM.mk added to configure CDEPS_DATM build *component_CDEPS_DOCN.mk added to configure CDEPS_DOCN build *component_CMEPS.mk CMEPS-INSTALL moved, default INTERNAL_PIO_INIT added *component_HYCOM.mk added extra build call to HYCOM model *module_EARTH_GRID_COMP.F90 added FRONT_CDEPS_DATM and FRONT_CDEPS_DOCN, added pio initialization Added diagnostics (Dan) *module_EARTH_GRID_COMP.F90 added connector diagnostics configuration Co-authored-by: Ufuk Turuncoglu <[email protected]> Co-authored-by: Daniel Rosen <[email protected]>
MinsukJi-NOAA
requested review from
DeniseWorthen,
binli2337,
junwang-noaa and
DusanJovic-NOAA
|
I ran UFS-weather-model regression tests with this NEMS changes on Hera. All gnu passed. All intel passed except for control_atm_aerosols, which resulted in MPI_Abort. Tried it 4 times and all failed. Can any one try this test case on Hera and verify? |
|
@MinsukJi-NOAA i am not sure but this could be an issue related with recently added GOCART chemistry component. |
|
@MinsukJi-NOAA where is your RT run directory with the failed control_atm_aerosols test? |
LOGDIR: /scratch2/NCEPDEV/stmp1/Minsuk.Ji/ufs-weather-model/tests/log_hera.intel RUNDIR: /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_RT/rt_64975/control_atm_aerosols |
|
The PET000 log shows |
I think you are right. #102 was merged in after this PR was submitted. |
|
Yes, there is no gocart in module_EARTH_GRID_COMP.F90. @uturuncoglu please merge with the latest nems develop branch. [Jun.Wang@hfe11 src]$ grep -i "gocart" module_EARTH_GRID_COMP.F90 |
…hafs_couplehycom_cdeps
|
@junwang-noaa @MinsukJi-NOAA @DeniseWorthen @uturuncoglu, I have just synced this feature/hafs_couplehycom_cdeps branch with the latest develop branch. |
|
control_atm_aerosols regression test passed. This PR is good for merge into UFS-weather-model @junwang-noaa @DeniseWorthen |
|
@DeniseWorthen <https://github.com/DeniseWorthen> can we merge this PR
with your ufs-weather-model PR #639?
…On Fri, Jul 16, 2021 at 9:05 AM Minsuk Ji ***@***.***> wrote:
control_atm_aerosols regression test passed. This PR is good for merge
into UFS-weather-model @junwang-noaa <https://github.com/junwang-noaa>
@DeniseWorthen <https://github.com/DeniseWorthen>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#106 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKEYGFAUPF2YZ5GPALTYAU7ZANCNFSM47RA5HOQ>
.
|
|
Yes that would be fine. I will switch my .gitmodules to point to the PR branch. |
|
@BinLiu-NOAA #104 is expected to be merged in today. Please update the feature/hafs_couplehycom_cdeps branch once again after that since this PR is scheduled for early next week. |
Will do. Thanks @MinsukJi-NOAA! |
|
@BinLiu-NOAA Could you please update to the NEMS commit from today? Thanks. |
…hafs_couplehycom_cdeps
|
@MinsukJi-NOAA @DeniseWorthen, have just synced with the latest develop branch as of this afternoon (07/16/2021). Thanks! |
This PR aims to bring data ocean support to NEMS, which is related to the issue #107. It also includes fix for reading modelio attributes from nems.configure and passing it to the CDEPS and CMEPS in case of it is defined.