Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged the atms_n20 yaml file into RDASApp. #236

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Conversation

xyzemc
Copy link
Contributor

@xyzemc xyzemc commented Nov 26, 2024

This PR is going to merge the ATMS NOAA_20 JEDI yaml file into RDASApp validated yaml file templates.
As the test in issue #203, atms_n20 data has been tested in MPAS_JEDI including all QC filters and bias correction. Not only the ioda data converted from regular feed bufr data has been tested, but also the ioda data converted from combined regular feed, DBNet, and ESRs bufr data has been tested too.
In addition, this atms_n20 yaml file has included the online domain check filters as described in and issue #224, and removed the 'circle domain check' filter

The Ens3Dvar ctests has passed with this yaml file added on top of the existing yaml file templates.


1/1 Test #3: rrfs_mpasjedi_2024052700_Ens3Dvar ...   Passed  1574.84 sec

The following tests passed:
        rrfs_mpasjedi_2024052700_Ens3Dvar

100% tests passed, 0 tests failed out of 1

Label Time Summary:
mpi            = 1574.84 sec*proc (1 test)
rdas-bundle    = 1574.84 sec*proc (1 test)
script         = 1574.84 sec*proc (1 test)

Total Test time (real) = 1575.56 sec


The atms_n20 ioda data and the satbias files are
atms_n20.satbias.nc4 atms_n20.satbias_cov.nc4 atms_n20.tlapse.txt ioda_atms_n20.nc
Which are under:
/scratch2/NCEPDEV/fv3-cam/Xiaoyan.Zhang/noscrub/JEDI/RDASApp_1107/expr/mpas_2024052700/data/obs

@SamuelDegelia-NOAA
Copy link
Contributor

Thanks @xyzemc, I have the same comments for this yaml as I do for #237.

@xyzemc
Copy link
Contributor Author

xyzemc commented Nov 27, 2024

Thanks @xyzemc, I have the same comments for this yaml as I do for #237.

Just added the localization part.

delippi
delippi previously approved these changes Dec 12, 2024
Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyzemc, two very picky comments on spacing. Other than that everything looks great!

delippi and others added 5 commits December 12, 2024 23:51
This PR updates the bufr2ioda yaml configurations to address issues
identified in the original files.
Finalize yamls for 187/287 metar observations with reasonable results.

See issue #46 for details.
This PR adds a Python converter for NEXRAD BUFR DUMP data.
…bers (#248)

The newly added FV3-JEDI test case only uses 20 members of the intended
30 member ensemble generated by @chunhuazhou.
@hu5970
Copy link
Contributor

hu5970 commented Dec 13, 2024

@HaidaoLin-NOAA Do you have further comments on this PR?

@hu5970
Copy link
Contributor

hu5970 commented Dec 13, 2024

@xyzemc Please sync with the develop branch.

@HaidaoLin-NOAA
Copy link

@HaidaoLin-NOAA Do you have further comments on this PR?
@hu5970 I am good for this PR to be merged now. Maybe it would be good to continue to check which QCs are actually working and how they work, the comparison with GSI QC, and clear sky vs. all sky in the future.

@hu5970 hu5970 merged commit c3ce325 into develop Dec 13, 2024
3 checks passed
@hu5970 hu5970 deleted the feature/atms_n20 branch December 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants