Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack Stack 1.8.0 #1062

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Conversation

FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA commented Oct 8, 2024

This PR upgrades UPP to spack-stack 1.8.0 and CRTMv3 alongside UFS WM PR 2453. Updates to the UPP RT scripts will be required across machines with the matching spack-stack 1.8.0 env.

@FernandoAndrade-NOAA FernandoAndrade-NOAA linked an issue Oct 8, 2024 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the enhancement New feature or request label Oct 8, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Oct 9, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA linked an issue Oct 9, 2024 that may be closed by this pull request
@AlexanderRichert-NOAA
Copy link
Contributor

To be safe, I created a PR based on your branch so you can review the changes: FernandoAndrade-NOAA#3

I tested it with sp, ip 5.0, and ip 5.1, and it builds successfully for all three.

@FernandoAndrade-NOAA FernandoAndrade-NOAA marked this pull request as ready for review November 6, 2024 18:39
@FernandoAndrade-NOAA
Copy link
Collaborator Author

CRTMv3 will be split into a different issue.

@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Spack Stack 1.8.0 and CRTMv3 Spack Stack 1.8.0 Nov 6, 2024
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Nov 12, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2 with no baseline changes.

@gspetro-NOAA
Copy link
Collaborator

gspetro-NOAA commented Nov 12, 2024

@FernandoAndrade-NOAA On Orion & Hercules, I'm getting the following error in nohup.out: Lmod has detected the following error: The following module(s) are unknown: "ip/5.0.0" "cmake/3.27.9". Tests passed on Hera w/no baseline changes.

Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTs pass on Hera, Orion, and Hercules with no baseline changes.

@gspetro-NOAA
Copy link
Collaborator

This PR is ready for merging.

@gspetro-NOAA gspetro-NOAA merged commit 4fba2fb into NOAA-EMC:develop Nov 20, 2024
3 checks passed
@jaymes-kenyon
Copy link
Contributor

Hi @FernandoAndrade-NOAA — When trying to compile UPP on Jet, I am encountering this issue:

[jet|fe4]/mnt/lfs5/BMC/rtwbl/kenyon/mpas_upp/UPP.mpas_updates/tests> ./compile_upp.sh 
Building for machine jet, compiler intel
Lmod has detected the following error:  These module(s) or extension(s) exist but cannot be loaded as requested: "hdf5/1.14.3",
"ip/5.0.0"
   Try: "module spider hdf5/1.14.3 ip/5.0.0" to see how to load the module(s).

Executing this command requires loading "hdf5/1.14.3" which failed while processing the following module(s):

    Module fullname  Module Filename
    ---------------  ---------------
    upp_common       /mnt/lfs5/BMC/rtwbl/kenyon/mpas_upp/UPP.mpas_updates/modulefiles/upp_common.lua
    jet              /mnt/lfs5/BMC/rtwbl/kenyon/mpas_upp/UPP.mpas_updates/modulefiles/jet.luaExecuting this command requires loading "ip/5.0.0" which failed while processing the following module(s):

    Module fullname  Module Filename
    ---------------  ---------------
    upp_common       /mnt/lfs5/BMC/rtwbl/kenyon/mpas_upp/UPP.mpas_updates/modulefiles/upp_common.lua
    jet              /mnt/lfs5/BMC/rtwbl/kenyon/mpas_upp/UPP.mpas_updates/modulefiles/jet.lua

Do you have any advice on what might need to be changed? Thanks!

@AlexanderRichert-NOAA
Copy link
Contributor

@jaymes-kenyon it should work if you point the jet modulefile to /contrib/spack-stack/spack-stack-1.8.0/envs/ue-intel-2021.5.0/install/modulefiles/Core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip 5/5.1 Update UPP with spack-stack 1.8.0
5 participants