Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRFS-MPAS applications: add several fields to output; remove "imp_physics" logic from INITPOST_MPAS #1088

Merged
merged 12 commits into from
Nov 22, 2024

Conversation

jaymes-kenyon
Copy link
Contributor

This PR addresses issue #1087 for MPAS applications. Namely:

  • For VIL, discontinue use of the local GRIB2 table
  • Add GSL's experimental ceiling fields to the GRIB2 output

Additionally, within "INITPOST_MPAS", many instances "if imp_physics..." are removed. These portions of the code (originally inherited from "INITPOST") initialize various hydrometeor arrays based upon the microphysics scheme. However, many of these "imp_physics" identifiers correspond to schemes in WRF-ARW and may not have relevance for MPAS. If future MPAS development requires this logic, then similar code structures can be re-introduced.

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon I ran an UPP standalone test with MPAS data files you provided at /home/Wen.Meng/stmp2/mpas_2024082112-after on Hera. Can you take a look at it and let me know if you see issues?
The three new fields you are proposing have been generated in WRFTWO dataset as:

3:1190255:ndata=1905141:undef=0:mean=0.143845:min=0:max=76.18:cos_wt_mean=0.144931:d=2024082100:VIL:entire atmosphere:12 hour fcst:
113:70778438:ndata=1905141:undef=827150:mean=4332.37:min=23.9683:max=14617.5:cos_wt_mean=4394.42:d=2024082100:CEIL:cloud ceiling:12 hour fcst:
114:73009041:ndata=1905141:undef=0:mean=11423.9:min=23.9683:max=20000:cos_wt_mean=11497.2:d=2024082100:CEIL:cloud base:12 hour fcst:

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — Thanks! Your test results look good; these are are new fields that are expected from this PR. Thanks for sharing!

@WenMeng-NOAA
Copy link
Collaborator

@gspetro-NOAA This PR is ready for the UPP RTs. There should be no baseline changes.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2 with no baseline changes.

@WenMeng-NOAA WenMeng-NOAA added Ready for commit queue No Baseline Change No baseline of the UPP regression tests are made. labels Nov 9, 2024
@gspetro-NOAA
Copy link
Collaborator

RTs pass on Hera, Orion, and Hercules without baseline changes.

Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready for merging.

@gspetro-NOAA gspetro-NOAA merged commit b3504d1 into NOAA-EMC:develop Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPAS No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPAS applications: fix / add several aviation fields, remove "if imp_physics..." logic from INITPOST_MPAS
3 participants