-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRFS-MPAS applications: add several fields to output; remove "imp_physics" logic from INITPOST_MPAS #1088
Conversation
…nto mpas_updates
@jaymes-kenyon I ran an UPP standalone test with MPAS data files you provided at /home/Wen.Meng/stmp2/mpas_2024082112-after on Hera. Can you take a look at it and let me know if you see issues?
|
@WenMeng-NOAA — Thanks! Your test results look good; these are are new fields that are expected from this PR. Thanks for sharing! |
@gspetro-NOAA This PR is ready for the UPP RTs. There should be no baseline changes. |
The UPP RTs have been completed on WCOSS2 with no baseline changes. |
RTs pass on Hera, Orion, and Hercules without baseline changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready for merging.
This PR addresses issue #1087 for MPAS applications. Namely:
Additionally, within "INITPOST_MPAS", many instances "if imp_physics..." are removed. These portions of the code (originally inherited from "INITPOST") initialize various hydrometeor arrays based upon the microphysics scheme. However, many of these "imp_physics" identifiers correspond to schemes in WRF-ARW and may not have relevance for MPAS. If future MPAS development requires this logic, then similar code structures can be re-introduced.