Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for time labeling in GRIB2 template 4.46 #1091

Merged

Conversation

EricJames-NOAA
Copy link
Contributor

This PR fixes the bug in time labeling for the RRFS 1-h average PM2.5 and PM10 variables. The code was tested for the RRFS_NA_3km system on Jet.

@WenMeng-NOAA WenMeng-NOAA linked an issue Nov 26, 2024 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Nov 26, 2024
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Thanks for catching and fixing bugs in RRFS products.
I have run the UPP standalone test with RRFS NA model history files at /home/Wen.Meng/stmp2/rrfs_2022022412-after on Hera.
There are the following updates in PRSLEV data set:

From
  751:4804768430:d=2022022412:MASSDEN:8 m above ground:10-11 hour ave fcst:aerosol=Missing:aerosol_size <2.5e-06
  752:4807749213:d=2022022412:MASSDEN:8 m above ground:10-11 hour ave fcst:aerosol=Missing:aerosol_size <1e-05
Into
  751:4804768430:d=2022022412:MASSDEN:8 m above ground:9-10 hour ave fcst:aerosol=Total aerosol:aerosol_size <2.5e-06
  752:4807749213:d=2022022412:MASSDEN:8 m above ground:9-10 hour ave fcst:aerosol=Total aerosol:aerosol_size <1e-05

Please let me know if you see issues in my test.

@EricJames-NOAA
Copy link
Contributor Author

@WenMeng-NOAA your test looks good to me! Thank you!

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit b37e67e into NOAA-EMC:release/rrfs_v1 Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for commit queue Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in time labeling for 1-h average PM2.5 and PM10 in RRFS
2 participants