Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block explict breaks domain reproducibility #974

Closed
DeniseWorthen opened this issue Apr 7, 2023 · 0 comments · Fixed by #975
Closed

block explict breaks domain reproducibility #974

DeniseWorthen opened this issue Apr 7, 2023 · 0 comments · Fixed by #975
Labels
bug Something isn't working

Comments

@DeniseWorthen
Copy link
Contributor

Describe the bug

This work is related to UFS Issue 1556

Prior to the merge of the WISE PR (#888), I tested the changes in my feature branch for the unstructured mesh extension to the mesh cap. Not being a wave modeler however, it did not occur to me that I needed to create a new mod_def to flip namelist switches. So I made my test using the wrong settings.

@aliabdolali provided me the correct values for the unstructured mesh + explicit from the standalone regtest (ww3_ufs1.1/input_unstr/ww3_grid_b.inp)

When I re-tested with an appropriate mod_def, the domain-decomposition test in my ATM-WAV case now failed. The difference in the exported Z0 between a 5PE and 10PE case is shown below

wavImp_Sw_z0_2021-03-22-24480

Clearly a ghost update is missing. I have a fix and will open a PR.

@DeniseWorthen DeniseWorthen added the bug Something isn't working label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant