Fix block explicit loop index

[DeniseWorthen]

Pull Request Summary

Extends the update of VA at the end of the block explict to use the ghost points also.

Description

Issue(s) addressed

• fixes block explict breaks domain reproducibility  #974 (LN 6599 in w3profsmd_pdlib.F90)
• also removes trailing whitespace and fixes the indenting for w3wavemd.F90 associated with the removal of an if statement (PR Ww3 wise merge develop #888)

Commit Message

Extend loop to include ghost points for VA

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[MatthewMasarik-NOAA]

@DeniseWorthen this is excellent news! What a great way to end the week, thank you.

On the last PR we merged (ww3_gint), @JessicaMeixner-NOAA and I noticed the restart files for the ww3_ufs1.1 grid b unstr regtest were not reproducing. It was not related to the gint PR so we added it to the list of known non-b4b tests and had planned to return to investigate. This is a real big help for us. I'll submit the regtests right now.

@aliabdolali @aronroland @thesser1 requesting reviews as the original developers

[MatthewMasarik-NOAA]

Update: I needed to re-run a test for this today, which is currently running. This is on track to be merged this afternoon or early tomorrow if no issues are found.

[MatthewMasarik-NOAA]

Code review Pass

Regtests Pass

• develop vs. fix confirm non-b4b except for the knowns, and ww3_ufs1.1 unstructured grid b.
  1.matrixCompFull.txt
  1.matrixCompSummary.txt
  matrixDiff.txt - too large to include.

• fix against itself confirms ww3_ufs1.1 unstructured grid b reproduces.
  2.matrixDiff.txt
  2.matrixCompFull.txt
  2.matrixCompSummary.txt

[MatthewMasarik-NOAA]

Thank you @DeniseWorthen for this bug fix for the new block explicit solver.

[aronroland]

Hey Denise, great catch! This is all valid!
Cheers
Aron