Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator log file for gridded output in production/GFS.v16 #1347

Draft
wants to merge 4 commits into
base: production/GFS.v16
Choose a base branch
from

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Jan 16, 2025

Pull Request Summary

Adds the writing of a log file to indicate that a particular gridded output file has finished writing.

Description

  • Provide a detailed description of what this PR does.

    • This indicator file will be used to signal to the post-processing scripts that a gridded output file is ready to be accessed and read. This is implemented in a simple way by reusing the Fortran IO unit number for the gridded output once that file has already been closed (thanks to @JessicaMeixner-NOAA for the suggestion!).
  • What bug does it fix, or what feature does it add?

    • This fixes an infrequent occurrence in the global-workflow where a gridded output file has an attempted read on it before the file has completed writing.
  • Is a change of answers expected from this PR?

    • No. This just addresses an issue that has occurred in post-processing.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • bug.
  • Are answer changes expected from this PR?
    • No.

Issue(s) addressed

Commit Message

w3iogomd.ftn: Add indicator log file write for gridded output

Check list

Testing

  • How were these changes tested?
    • So far, testing has been done in standalone mode with a modified regtest which is verified by a separate process checking for out_grd files and indicator files.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • Yes, exisiting regtests which output gridded files can be used for this testing.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • No. It is not a requirement for the production/GFS.v16 branch, but will be done as a sanity check.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • No changes expected.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • To be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant