Remove Noah-WRFv4, contains "reduce memory required by MERRA2 data" (#410) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge to latest develop
The HAFS related developments for the write_grid_component (#10)
change ifmin to zero at fh00 for inline POST (NOAA-EMC#14)
merge to latest develop
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (NOAA-EMC#30)
GFSv16 netcdf post ficein cpl (NOAA-EMC#48)
Regain bit-for-bit identical results between IPD and CCPP for coupled…
Merge NCAR:dtc/develop into develop 2020/04/14 (NOAA-EMC#98)
Port to Orion (NOAA-EMC#102)
Remove dynamic CCPP build (NOAA-EMC#103)
…ove-noah-wrfv4-bugfix-mp-thompson
…ove-noah-wrfv4-bugfix-mp-thompson
…ove-noah-wrfv4-bugfix-mp-thompson
…ove-noah-wrfv4-bugfix-mp-thompson
… into remove-noah-wrfv4-bugfix-mp-thompson
climbfuji
changed the title
climbfuji
force-pushed
the
remove-noah-wrfv4-bugfix-mp-thompson
branch
from
bfe5041
to
2815425
Compare
|
approved. looks fine to me
…On Thu, Oct 28, 2021 at 9:47 AM Dom Heinzeller ***@***.***> wrote:
@climbfuji <https://github.com/climbfuji> requested your review on: #398
<#398> Remove Noah-WRFv4, contains
"reduce memory required by MERRA2 data" (#410
<#410>).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#398 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIOLMZ7RSF53SPQD4LDUJFH6DANCNFSM5EWQ3Q4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
…ove-noah-wrfv4-bugfix-mp-thompson
junwang-noaa
approved these changes
Oct 29, 2021
|
ccpp-physics hash is correct (6912955), ready to merge |
DeniseWorthen
approved these changes
Oct 29, 2021
DusanJovic-NOAA
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the Noah WRFv4 scheme that was added to ccpp-physics for testing the HWRF physics in the UFS, alongside with the variables required by this scheme only and a suite definition file that is not in use and that has been replaced by other HAFS SDFs.
Contains #410 (reduce memory required by MERRA2 data) from @DeniseWorthen.
Issue(s) addressed
Testing
See ufs-community/ufs-weather-model#831
Dependencies
NCAR/ccpp-physics#743
#398
ufs-community/ufs-weather-model#831