-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two way fire coupling to fv3atm #815
Conversation
* added: inst_pres_levels (statein%prsl) * added: inst_geop_levels (statein%phil) * added: inst_zonal_wind_levels (statein%ugrs) * added: inst_merid_wind_levels (statein%vgrs) * added: inst_surface_roughness (sfcprop%zorl) * updated: inst_temp_height2m (sfcprop%t2m) * updated: inst_spec_humid_height2m (sfcprop%q2m) * updated: inst_pres_height_surface (statein%pgr) * updated: mean_prec_rate (sfcprop%tprcp / rtimek)
* added: inst_rainfall_amount (sfcprop%tprcp)
* add hflx_fire and evap_fire to FV3 imports * add cpl_fire flag and variable initialization * update ccpp/physics
* added surface emissions fire_smoke imports * initialized the variables and fsmoke tracer index
* fix coupling fields * merge upstream for ccpp/physics Co-authored-by: Masih Eghdami <[email protected]>
@danrosen25 @masih-e Please review/merge esmf-org#1. This updates this branch to work with the top of develop. This should be merged AFTER esmf-org/ccpp-physics#1 |
After merging in the top of develop, we need to remove the draft status too. |
@danrosen25 Thanks for merging. Please review and merge esmf-org/CMEPS#1 next. And, please remember to remove the draft status on this PR in order to enter the UFS merge queue. |
Done, and once the PR for ccpp is complete we can update the branch location and mark this as ready. |
We can't merge ufs-community/ccpp-physics#193 and update .gitmodules here until UFS code managers have tested and approved the chain of PRs from fv3atm upwards, and they won't start the final testing/review process until this is out of draft mode. |
Description
This PR satisfies two-way coupling requirements for fv3atm and the community fire behavior model. It includes an option to enable fire coupling 'cpl_fire', which enables several export fields needed by the fire behavior model. It also includes new import fields for ccpp physics: heat flux from fire, upward specific humidity flux from fire, and smoke tracer. This is a draft PR until the ccpp physics coupling dependency is satisfied and the submodule can be updated appropriately.
Co-author: @masih-e
Issue(s) addressed
Testing
The rt.conf test has been used and one test from each compile line has been executed on derecho with the intel compiler. The baseline results have not changed but a new regression test has been added for coupling atm and fbh (fire behavior). This test is here: New Test
Dependencies
This dependency needs to be satisfied before the fv3atm changes can be complete
ufs-community/ccpp-physics#193