Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rdbfmsua.x with a traditional makefile #57

Merged
merged 11 commits into from
Mar 20, 2024

Conversation

aerorahul
Copy link
Contributor

Description

This PR:

  • builds rdbfmsua.x with a traditional makefile instead of cmake due to problems with gempak and cmake. The issues are documented in Build rdbfmsua on Hera, Orion, and WCOSS2 #50
  • skips building the above executable if the modulefile for this executable is not found.
  • only supports wcoss2, hera and orion at the moment where gempak is available.

Fixes #54

Type of change

  • Maintenance

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Builds on hera, wcoss2
Runs will be tested at a later time with the workflow.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Build script was checking for the existance of a modulefile for rdbfmsua,
but did not include the '.lua' that exists in the filename. Changed the
detection to instead try to load the file and detect when there is an
error.
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ad6592f into develop Mar 20, 2024
4 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/rdbfmsua branch March 20, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore rdbfmsua build
2 participants