Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SENDCOM from make_ntc_bull #62

Merged

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Apr 12, 2024

Description

The use of SENDCOM was retired in global workflow. make_ntc_bull is updated to match.

Refs NOAA-EMC/global-workflow#2479

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Part of global-workflow on WCOSS

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. though, I would have just removed SENDCOM as the title suggests and leave out the rest as is.

The use of SENDCOM was retired in global workflow. make_ntc_bull is updated
to match.

Refs NOAA-EMC/global-workflow#2479
@WalterKolczynski-NOAA
Copy link
Contributor Author

Reverted the indentation fixes.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit d77c3c9 into NOAA-EMC:develop Apr 12, 2024
3 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/fbwind branch April 13, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants