Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Gaea #67

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Build on Gaea #67

merged 3 commits into from
Apr 22, 2024

Conversation

DavidBurrows-NCO
Copy link
Contributor

@DavidBurrows-NCO DavidBurrows-NCO commented Apr 19, 2024

Description

Add/update module file scripts for compiling gfs_utils on Gaea-C5

Refs #66

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on Gaea-C5

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have 1 comment that holds this PR back.
It is the same comment I had in #64

modulefiles/gfsutils_common.lua Outdated Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for adding the capability to build on Gaea.

@aerorahul aerorahul merged commit f9b33ae into NOAA-EMC:develop Apr 22, 2024
3 checks passed
@DavidBurrows-NCO
Copy link
Contributor Author

@aerorahul Morning..The epic software team got back to me yesterday and had a small correction to the gaea module file for gfs_utils..It doesn't change anything but eliminates a python version number warning message. I have committed that change and rebuilt. What's the process to correct this PR? New PR for bug fix? Reopen here? Thanks

@aerorahul
Copy link
Contributor

@aerorahul Morning..The epic software team got back to me yesterday and had a small correction to the gaea module file for gfs_utils..It doesn't change anything but eliminates a python version number warning message. I have committed that change and rebuilt. What's the process to correct this PR? New PR for bug fix? Reopen here? Thanks

Yes. A new PR with a hotfix/bugfix is generally how this is handled.

@DavidBurrows-NCO
Copy link
Contributor Author

Great. Will do. Thanks.

@DavidBurrows-NCO DavidBurrows-NCO changed the title Build on Gaea for APP=ATM Build on Gaea Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants