Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules on orion for rocky 8 #72

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

aerorahul
Copy link
Contributor

Description

This PR:

  • updates modulefile for Orion to the Rocky8 OS upgrade
  • gempak module is not available on Orion+Rocky8 after the upgrade. rdbfmsua.x will not be built.

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES (rdbfmsua.x is no longer built on orion due to gempak unavailability)
  • Does this change require a documentation update? YES (if there is any)

How has this been tested?

  • build tested on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Jun 28, 2024

Detect machine also needs to be updated as both Orion and Hercules now have /apps/other. Suggest changing

elif [[ -d /work ]]; then
# We are on MSU Orion or Hercules
if [[ -d /apps/other ]]; then
# We are on Hercules
MACHINE_ID=hercules
else
MACHINE_ID=orion
fi

to the same as the GSI:

 elif [[ -d /work ]]; then 
  mount=$(findmnt -n -o SOURCE /home)
  if [[ ${mount} =~ "hercules" ]]; then
    MACHINE_ID=hercules
  else
    MACHINE_ID=orion
  fi

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DavidHuber-NOAA DavidHuber-NOAA merged commit 02ce084 into develop Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants