Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip the build for GFS and GEFS with waves #2462

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Flip the build for GFS and GEFS with waves #2462

merged 2 commits into from
Apr 8, 2024

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Apr 5, 2024 •
edited
Loading

Description

This PR:

  • builds the unstructured waves as default when invoked with build_all.sh.
  • updates the CI testing infrastructure to handle this change.
  • updates the documentation to reflect this change in behaviour.

To build with structured grid for waves, the flag -w needs to be passed to ./build_all.sh. Previously, this would trigger the unstructured grid. Since GFSv17 will move to unstructured grid as default for waves, this makes it easier for a majority of developers.

Resolves #2461

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 5, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 5, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

This merge will need a corresponding announcement of the change.

@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Apr 5, 2024
@emcbot
Copy link

emcbot commented Apr 6, 2024

CI FAILED Orion at 04 05 22:38:34
Built and ran in directory /work2/noaa/stmp/CI/ORION/2462

@emcbot emcbot added the CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed label Apr 6, 2024
@TerrenceMcGuinness-NOAA
Copy link
Collaborator

TerrenceMcGuinness-NOAA commented Apr 6, 2024 •
edited
Loading

This PR just came on-line and I was doing some late night house cleaning of the Jenkins scrub space and inadvertently killed this job on Orion. I'm restarting the Orion CI run now.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed labels Apr 6, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Apr 6, 2024
@emcbot
Copy link

emcbot commented Apr 6, 2024

CI SUCCESS Hera at 04 06 01:33:16

Built and ran in directory /scratch1/NCEPDEV/global/CI/2462

@emcbot emcbot added the CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully label Apr 6, 2024
JessicaMeixner-NOAA
JessicaMeixner-NOAA approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this helps with the errors. Thanks for the update @aerorahul

@aerorahul
Copy link
Contributor Author

Hope this helps with the errors. Thanks for the update @aerorahul

Thanks for the review.

I am not aware of any errors that this PR fixes.

I am aware that developers are accustomed to building for the GFS with ./build_all.sh (without -w) and that has led to stalled forecast jobs because the forecast executable is built without unstructured grid options and the configuration requires it.

@aerorahul aerorahul merged commit 0237dba into NOAA-EMC:develop Apr 8, 2024
10 checks passed
@aerorahul aerorahul deleted the feature/issue-2461 branch April 8, 2024 13:41
@JessicaMeixner-NOAA
Copy link
Contributor

Hope this helps with the errors. Thanks for the update @aerorahul

Thanks for the review.

I am not aware of any errors that this PR fixes.

I am aware that developers are accustomed to building for the GFS with ./build_all.sh (without -w) and that has led to stalled forecast jobs because the forecast executable is built without unstructured grid options and the configuration requires it.

@aerorahul that's what I meant by errors.

danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 8, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c3d43b9 
* upstream/develop:
  Flip the build for GFS and GEFS with waves (NOAA-EMC#2462)
  Add new data sources used in GFS v16.3.12 (NOAA-EMC#2283)
  The soca fix path is needed in config.prepoceanobs (NOAA-EMC#2460)
  Turn off reducedgrid in the EnKF (NOAA-EMC#2456)
  Rename generate_com to declare_from_tmpl (NOAA-EMC#2453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flip GFS and GEFS default builds for waves
5 participants
@aerorahul @WalterKolczynski-NOAA @emcbot @TerrenceMcGuinness-NOAA @JessicaMeixner-NOAA