-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snow DA update and recentering for the EnKF forecasts #2690
Merged
WalterKolczynski-NOAA
merged 135 commits into
NOAA-EMC:develop
from
CoryMartin-NOAA:feature/snow-ensemble
Aug 23, 2024
Merged
Changes from 73 commits
Commits
Show all changes
135 commits
Select commit
Hold shift + click to select a range
b0656aa
start to add new task
CoryMartin-NOAA d16119d
add new j-job
CoryMartin-NOAA b4c97f8
Save to do some initial testing
CoryMartin-NOAA 3667349
more updates
CoryMartin-NOAA accc4f4
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA e565f21
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 81b7b6e
end of day commit
CoryMartin-NOAA 3aaa8f6
End of day/week commit
CoryMartin-NOAA 7085716
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA 29641b2
save
CoryMartin-NOAA 531136a
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
CoryMartin-NOAA 7491c35
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA d57e12f
snow changes
CoryMartin-NOAA 89fd461
end of day commit
CoryMartin-NOAA f26822e
stage files is working
CoryMartin-NOAA 2460af1
save updates
CoryMartin-NOAA 057996d
more updates
CoryMartin-NOAA 146dc60
make norm happy
CoryMartin-NOAA cff98a0
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA d7afb7b
norm is an angry old man
CoryMartin-NOAA eb5716d
remove esnowanl from enkfgfs
CoryMartin-NOAA 256e182
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
CoryMartin-NOAA 6a57a64
end of day commit
CoryMartin-NOAA ebb3c31
fregrid working but seems a bit hacky
CoryMartin-NOAA 2bdee22
norms and remove commented out code
CoryMartin-NOAA 99fdfbe
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 42b3fbe
update snow ens
CoryMartin-NOAA a950c80
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA f380223
update some submodules
CoryMartin-NOAA 73894dc
update some things
CoryMartin-NOAA 79faad9
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
CoryMartin-NOAA 39624f8
update snow stage yaml
CoryMartin-NOAA 758287d
whoops
CoryMartin-NOAA b65f381
hack increment times
CoryMartin-NOAA fd15a24
dates for increment
CoryMartin-NOAA 4cfbe31
fregrid names
CoryMartin-NOAA 9145004
updates to test
CoryMartin-NOAA aeb3f79
fix method call
CoryMartin-NOAA 06c8e3a
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
CoryMartin-NOAA f23aa20
coding norms
CoryMartin-NOAA 4ba1cdc
end of week commit
CoryMartin-NOAA d0d711a
one more end of week commit
CoryMartin-NOAA 18e7bd4
smore changes
CoryMartin-NOAA 7370a0c
Merge branch 'feature/snow-ensemble' of https://github.com/CoryMartin…
CoryMartin-NOAA b029f90
ensmean to ensstat
CoryMartin-NOAA 18aaafa
IAU changes
CoryMartin-NOAA 135c57f
coding norms + more IAU fixes
CoryMartin-NOAA dde7463
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 9c47927
Update gdas
CoryMartin-NOAA 33f6080
update enkf sfc update
CoryMartin-NOAA 0643c95
more changes
CoryMartin-NOAA 54539cd
update ci case
CoryMartin-NOAA 554b545
fix dependencies
CoryMartin-NOAA aa43118
ignore these bufr2ioda links
CoryMartin-NOAA d6dae13
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA fa8dd8a
fixing some bugs
CoryMartin-NOAA c24d026
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
CoryMartin-NOAA ea0bbf9
shellcheck
CoryMartin-NOAA 90cd928
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA eb4cb43
more shellcheck
CoryMartin-NOAA f817b7e
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA aa45f33
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA a5a54ec
update gdas hash
CoryMartin-NOAA f31a90e
address reviewer comments
CoryMartin-NOAA 4e64b86
update name of test
CoryMartin-NOAA 1b9b085
Update env/WCOSS2.env
CoryMartin-NOAA 80d4630
no need for a non-standard DATA directory
CoryMartin-NOAA 9897e71
Update scripts/exgdas_enkf_sfc.sh
CoryMartin-NOAA f85c880
address reviewer comments
CoryMartin-NOAA 55f2fe9
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 00c7d8e
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 57f0af1
Merge branch 'feature/snow-ensemble' of http://github.com/corymartin-…
CoryMartin-NOAA a207fe5
fix template issue + updates for g-w develop merge
CoryMartin-NOAA 4f81ded
Address Jiarui's comments
CoryMartin-NOAA ea6c4b4
Merge branch 'develop' into feature/snow-ensemble
DavidHuber-NOAA 57936f0
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA e2979b1
No NLN but NCP
CoryMartin-NOAA 795e1d0
Update jobs/rocoto/esnowanl.sh
CoryMartin-NOAA e6c3331
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 1415c3d
address comments
CoryMartin-NOAA d496745
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
CoryMartin-NOAA e98a65f
Update WCOSS2.env
CoryMartin-NOAA 57145e5
use new wxflow technique for templates
CoryMartin-NOAA 9c35852
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
CoryMartin-NOAA bbbb231
some python issues
CoryMartin-NOAA 947a727
more issues
CoryMartin-NOAA 7c6b91f
fix templating
CoryMartin-NOAA 9658e3d
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 114ff36
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 43aa0a1
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
CoryMartin-NOAA 2a1e544
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA 4a2af93
address some comments
CoryMartin-NOAA 591fe9d
Merge branch 'feature/snow-ensemble' of https://github.com/corymartin…
CoryMartin-NOAA 1717a16
update GDAS hash
CoryMartin-NOAA e72868a
you shall not pass
CoryMartin-NOAA f860cc4
just remove mkdata stuff
CoryMartin-NOAA 6d00e5c
some updates
CoryMartin-NOAA 9180ea0
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA dd493ad
address pynorms
CoryMartin-NOAA 2972225
Address clara's comments + fregrid_exe
CoryMartin-NOAA f36c33f
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 1c555c6
shellcheck
CoryMartin-NOAA 5d7c9b7
update from cdump to run
CoryMartin-NOAA dd2439e
update fregrid arg lists
CoryMartin-NOAA 0422c9f
fix comments
CoryMartin-NOAA a1e1acc
Merge branch 'develop' into feature/snow-ensemble
aerorahul ad98bfe
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA df156fb
Fix npe_apply_inc issue
CoryMartin-NOAA bfc9e43
fix missing quote
CoryMartin-NOAA 09b1133
remove CDUMP
CoryMartin-NOAA 92af672
update gdas hash
CoryMartin-NOAA ff2ba68
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA b193128
Merge branch 'NOAA-EMC:develop' into develop
CoryMartin-NOAA 129a925
Merge branch 'NOAA-EMC:develop' into feature/snow-ensemble
CoryMartin-NOAA 9679aa9
update increment mask
CoryMartin-NOAA 56b940c
Marine DA updates (#2802)
guillaumevernieres efb7804
Feature/get arch adds an empty archive job to GEFS system (#2772)
AntonMFernando-NOAA cdac7bb
Check that a PR driver is still running before trying to kill it (#2799)
DavidHuber-NOAA 03aee25
Revert "remove CDUMP"
CoryMartin-NOAA 36bc71a
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 960b830
update gdas hash
CoryMartin-NOAA 6cb4178
change hash
CoryMartin-NOAA 16b0747
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 597d499
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA bc22c00
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 48b1cca
Add Gaea C5 to CI (#2814)
AnilKumar-NOAA 9280086
Jenkins Pipeline Updates (#2815)
TerrenceMcGuinness-NOAA 5ed6dec
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA d8e0e82
remove to_ymdh
CoryMartin-NOAA 06d0fc2
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 6f732a1
update gdas hash
CoryMartin-NOAA 886a9f1
not worry about threads on wcoss
CoryMartin-NOAA 60ccca1
update gdas hash
CoryMartin-NOAA b3f8e5b
Merge branch 'develop' into feature/snow-ensemble
CoryMartin-NOAA 1cb436e
skip wcoss2 for ci for now
CoryMartin-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
#! /usr/bin/env bash | ||
|
||
source "${HOMEgfs}/ush/preamble.sh" | ||
source "${HOMEgfs}/ush/jjob_header.sh" -e "esnowanl" -c "base esnowanl" | ||
|
||
############################################## | ||
# Set variables used in the script | ||
############################################## | ||
# Ignore possible spelling error (nothing is misspelled) | ||
# shellcheck disable=SC2153 | ||
GDUMP="gdas" | ||
GDUMP_ENS="enkfgdas" | ||
export GDUMP | ||
|
||
############################################## | ||
# Begin JOB SPECIFIC work | ||
############################################## | ||
# Generate COM variables from templates | ||
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
COMIN_OBS:COM_OBS_TMPL \ | ||
COMOUT_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL \ | ||
COMOUT_CONF:COM_CONF_TMPL | ||
MEMDIR="ensstat" YMD=${PDY} HH=${cyc} declare_from_tmpl \ | ||
COMOUT_SNOW_ANALYSIS:COM_SNOW_ANALYSIS_TMPL | ||
|
||
mkdir -p "${COMOUT_SNOW_ANALYSIS}" "${COMOUT_CONF}" | ||
|
||
for imem in $(seq 1 "${NMEM_ENS}"); do | ||
memchar="mem$(printf %03i "${imem}")" | ||
MEMDIR=${memchar} RUN=${GDUMP_ENS} YMD=${PDY} HH=${cyc} declare_from_tmpl COMOUT_SNOW_ANALYSIS:COM_SNOW_ANALYSIS_TMPL | ||
mkdir -p "${COMOUT_SNOW_ANALYSIS}" | ||
done | ||
|
||
############################################################### | ||
# Run relevant script | ||
|
||
EXSCRIPT=${SNOWANLPY:-${SCRgfs}/exglobal_snow_ensemble_analysis.py} | ||
${EXSCRIPT} | ||
status=$? | ||
(( status != 0 )) && exit "${status}" | ||
|
||
############################################## | ||
# End JOB SPECIFIC work | ||
############################################## | ||
|
||
############################################## | ||
# Final processing | ||
############################################## | ||
if [[ -e "${pgmout}" ]] ; then | ||
cat "${pgmout}" | ||
fi | ||
|
||
########################################## | ||
# Remove the Temporary working directory | ||
########################################## | ||
cd "${DATAROOT}" || exit 1 | ||
[[ "${KEEPDATA}" = "NO" ]] && rm -rf "${DATA}" | ||
|
||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#! /usr/bin/env bash | ||
|
||
source "${HOMEgfs}/ush/preamble.sh" | ||
|
||
############################################################### | ||
# Source UFSDA workflow modules | ||
. "${HOMEgfs}/ush/load_ufsda_modules.sh" | ||
status=$? | ||
[[ ${status} -ne 0 ]] && exit "${status}" | ||
|
||
export job="esnowanl" | ||
export jobid="${job}.$$" | ||
|
||
############################################################### | ||
# setup python path for workflow utilities and tasks | ||
wxflowPATH="${HOMEgfs}/ush/python:${HOMEgfs}/ush/python/wxflow/src" | ||
PYTHONPATH="${PYTHONPATH:+${PYTHONPATH}:}${wxflowPATH}" | ||
export PYTHONPATH | ||
CoryMartin-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
############################################################### | ||
# Execute the JJOB | ||
"${HOMEgfs}/jobs/JGLOBAL_SNOW_ENSEMBLE_ANALYSIS" | ||
status=$? | ||
exit "${status}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#! /usr/bin/env bash | ||
|
||
########## config.esnowanl ########## | ||
# configuration common to snow ensemble analysis tasks | ||
|
||
echo "BEGIN: config.esnowanl" | ||
|
||
# Get task specific resources | ||
source "${EXPDIR}/config.resources" esnowanl | ||
|
||
export JCB_BASE_YAML="${PARMgfs}/gdas/snow/jcb-base.yaml.j2" | ||
export JCB_ALGO_YAML="${PARMgfs}/gdas/snow/jcb-fv3jedi_land_ensrecenter.yaml.j2" | ||
|
||
export JEDI_FIX_YAML="${PARMgfs}/gdas/atm_jedi_fix.yaml.j2" | ||
export SNOW_ENS_STAGE_TMPL="${PARMgfs}/gdas/snow_stage_ens_update.yaml.j2" | ||
export SNOW_OROG_STAGE_TMPL="${PARMgfs}/gdas/snow_stage_orog.yaml.j2" | ||
export SNOW_ENS_FINALIZE_TMPL="${PARMgfs}/gdas/snow_finalize_ens_update.yaml.j2" | ||
|
||
# Name of the executable that applies increment to bkg and its namelist template | ||
export APPLY_INCR_EXE="${EXECgfs}/apply_incr.exe" | ||
export ENS_APPLY_INCR_NML_TMPL="${PARMgfs}/gdas/snow/letkfoi/ens_apply_incr_nml.j2" | ||
|
||
export io_layout_x=@IO_LAYOUT_X@ | ||
export io_layout_y=@IO_LAYOUT_Y@ | ||
|
||
export JEDIEXE=${EXECgfs}/gdasapp_land_ensrecenter.x | ||
export FREGRID=${EXECgfs}/fregrid.x | ||
aerorahul marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
echo "END: config.esnowanl" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will depend on the other PR that adds
wxflow
toload_ufsda_modules.sh
. That will greatly simplify things.Just a note as this may or may not be needed based on time of merge