Create the input.nml file from global_control.nml.IN template #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This represents the first pass of the parsing script. Tests show that it is working as intended. Next iterations will trim down the number of arguements as needed.
This commit reduced some of the redundant calls and settings that were default in the global_control.nml.IN. Changes were conservative to avoid future conflicts with variables that need to have dynamic values. Comments were also removed that were present in the previous commit.
Added a new function to compile the namelist after all environmental variables have been defined. Allows for different coupling cases to aggregate a finished namelist via atparse.
|
This is currently a work in progress. The UFS regression tests are currently being updated to work with GFSv17 and officially deprecating v16. This will probably cause changes to the global namelist template, so this will remain a draft until then. Once I'm done updating the RT side and have a finalized global_control.nml.IN file, I'll circle back to this and finish up the rest. The commit should be ~90% of the way there. Jun and I wanted to get this PR posted in case other people on the GW side wanted to look at the changes and to gather any input. The global_control.nml.IN file added here will be removed in the final commit (just here for testing). The 'unified' namelist will be on the UFS regression test side once the PR is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to bridge the GW ad regression test workflow. The regression tests have a new global_control.nml.IN for all global regression tests. The idea is to allow the GW framework to use this template to generate the input.nml that is used in the GW.
By pulling from a unified namelist, changes made on the regression test side can easily be added to the GW side and vice versa.
The parsing scripts in ./ush/ will be changed to use atparse to generate the input.nml file from the global_control.nml.IN namelist.
This PR will resolve #2731 and ufs-community/ufs-weather-model#1664.
Type of change
Change characteristics
How has this been tested?
Checklist