Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fire blending to GOCART #2883

Open
wants to merge 69 commits into
base: develop
Choose a base branch
from
Open

Add fire blending to GOCART #2883

wants to merge 69 commits into from

Commits on Sep 13, 2024

  1. add bones to the fire blending in the prep_emissions job

    @bbakernoaa
    bbakernoaa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c8e6344 View commit details
    Browse the repository at this point in the history

  2. pycodestyle

    @bbakernoaa
    bbakernoaa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4d81cb8 View commit details
    Browse the repository at this point in the history

  3. pycodestyle fixes

    @bbakernoaa
    bbakernoaa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5f86abd View commit details
    Browse the repository at this point in the history

  4. fix prep_emission jjob

    @bbakernoaa
    bbakernoaa committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    62dbf31 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ae3f599 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Merge branch 'develop' into feature/fire_blending

    @aerorahul
    aerorahul authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    16e21bd View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Cleanup job for GEFS (NOAA-EMC#2919) 

    As forecast ensemble jobs are added to the global workflow, this PR
ensures the output is being cleaned up properly once it is no longer
needed.
  Resolves NOAA-EMC#833
    @AntonMFernando-NOAA @bbakernoaa
    AntonMFernando-NOAA authored and bbakernoaa committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b22d7bc View commit details
    Browse the repository at this point in the history

  2. Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917) 

    This PR updates the parm/config/gfs/config.resources and env/WCOSS2.env
files for the BUFR sounding job "postsnd." It includes adjustments to
resource settings such as tasks per node and memory allocations for
various GFS resolutions, including C768, C1152, and others.

Here are the proposed changes:

C768: 7 nodes, 21 tasks per node
C1152: 16 nodes, 9 tasks per node
    @BoCui-NOAA @bbakernoaa
    BoCui-NOAA authored and bbakernoaa committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9965857 View commit details
    Browse the repository at this point in the history

  3. Update global atmos upp job to use COMIN/COMOUT (NOAA-EMC#2867) 

    NCO has requested that each COM variable specify whether it is an input
or an output. This completes that process for the global-workflow
Unified Post Processor (UPP) task.
Refs: NOAA-EMC#2451
    @mingshichen-noaa @bbakernoaa
    mingshichen-noaa authored and bbakernoaa committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5b57604 View commit details
    Browse the repository at this point in the history

  4. Update to obsproc/v1.2.0 and prepobs/v1.1.0 (NOAA-EMC#2903) 

    This PR updates the `develop` branch to use the newer operational
`obsproc/v1.2.0` and `prepobs/v1.1.0`. The obsproc/prepobs installs in
glopara space on supported platforms use tags cut from the `dev/gfsv17`
branches in the respective repos. The installation of `prepobs/v1.1.0`
on WCOSS2 is called "gfsv17_v1.1.0" to help avoid GFSv16 users using it
instead of the operational module.

Also, the `HOMEobsproc` path is updated to set an empty default for
`obsproc_run_ver`. This both removes the need to set a default (and
constantly update it, which is duplication) and avoid the unset variable
error when the fcst jobs use their own load module script that does not
know `obsproc_run_ver`:
```
export HOMEobsproc="${BASE_GIT:-}/obsproc/v${obsproc_run_ver:-}"
```

This PR also reverts the prepobs and fit2obs installs on MSU back to the
glopara space from the temporary `/work/noaa/global/kfriedma/glopara`
space installs.

Lastly, this PR also includes updates to complete issue NOAA-EMC#2844 (merge
`build.spack.ver` and `run.spack.ver`).

Resolves NOAA-EMC#2291
Resolves NOAA-EMC#2840
Resolves NOAA-EMC#2844
    @KateFriedman-NOAA @bbakernoaa
    KateFriedman-NOAA authored and bbakernoaa committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1f95b2b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'remotes/upstream/develop' into feature/… 

    …fire_blending
    @bbakernoaa
    bbakernoaa committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    eb8bc78 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'develop' into feature/fire_blending

    @aerorahul
    aerorahul authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9a9a874 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Update parm/prep/aero_emissions.yaml 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3b87649 View commit details
    Browse the repository at this point in the history

  2. Update parm/prep/aero_emissions.yaml 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    21d7bad View commit details
    Browse the repository at this point in the history

  3. Update parm/prep/aero_emissions.yaml 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    58e7280 View commit details
    Browse the repository at this point in the history

  4. Update parm/prep/aero_emissions.yaml 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f74f471 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    945508f View commit details
    Browse the repository at this point in the history

  2. add coarsen_scale to yaml and use in aero_emission.py

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eb53925 View commit details
    Browse the repository at this point in the history

  3. remove debugging print statements

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    55d7ada View commit details
    Browse the repository at this point in the history

  4. Update parm/prep/aero_emissions.yaml 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4aec698 View commit details
    Browse the repository at this point in the history

  5. add init doc block

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2d8155d View commit details
    Browse the repository at this point in the history

  6. remove comment

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    389f9da View commit details
    Browse the repository at this point in the history

  7. move syncing to initialize

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2875b6e View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'refs/remotes/origin/feature/fire_blendi… 

    …ng' into feature/fire_blending
    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    404131d View commit details
    Browse the repository at this point in the history

  9. add loger info for this and error trapping

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ca87ed9 View commit details
    Browse the repository at this point in the history

  10. add more changes

    @bbakernoaa
    bbakernoaa committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9ff202f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. more changes, docstrings, error checking etc

    @bbakernoaa
    bbakernoaa committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    55d5892 View commit details
    Browse the repository at this point in the history

  2. pycodestyle changes

    @bbakernoaa
    bbakernoaa committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f853e4f View commit details
    Browse the repository at this point in the history

  3. add blended emission option

    @bbakernoaa
    bbakernoaa committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4dfba87 View commit details
    Browse the repository at this point in the history

  4. copy blending from COMOUT if AERO_EMIS_FIRE == blending

    @bbakernoaa
    bbakernoaa committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc5c8bc View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Update ush/forecast_postdet.sh 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    dbc63e8 View commit details
    Browse the repository at this point in the history

  2. Update ush/forecast_postdet.sh 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a43e0c6 View commit details
    Browse the repository at this point in the history

  3. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6836bfc View commit details
    Browse the repository at this point in the history

  4. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4e30517 View commit details
    Browse the repository at this point in the history

  5. changing resources

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d0b20b4 View commit details
    Browse the repository at this point in the history

  6. remove starthour

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1fa7df1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d1dad35 View commit details
    Browse the repository at this point in the history

  8. fix pycodestyle

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4a696b3 View commit details
    Browse the repository at this point in the history

  9. complete passing vars from yaml

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8d9a124 View commit details
    Browse the repository at this point in the history

  10. pycodestyle again

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    42da2da View commit details
    Browse the repository at this point in the history

  11. fix passing matching vars arrays from yaml file

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9753ddc View commit details
    Browse the repository at this point in the history

  12. more changes to fix issues

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    84edf69 View commit details
    Browse the repository at this point in the history

  13. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9583817 View commit details
    Browse the repository at this point in the history

  14. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ec4f462 View commit details
    Browse the repository at this point in the history

  15. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    65572fa View commit details
    Browse the repository at this point in the history

  16. add changes to copy the data for each fire case and add a method that… 

    … if hfed is used just to transform the data... ie don't really process
    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ffb8664 View commit details
    Browse the repository at this point in the history

  17. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Rahul Mahajan <[email protected]>
    @bbakernoaa @aerorahul
    bbakernoaa and aerorahul authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7a1efd1 View commit details
    Browse the repository at this point in the history

  18. last suggetions?

    @bbakernoaa
    bbakernoaa committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b628f29 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3c170db View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. add with command when opening files

    @bbakernoaa
    bbakernoaa committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d44c5b9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/feature/fire_blendi… 

    …ng' into feature/fire_blending
    @bbakernoaa
    bbakernoaa committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5d2f493 View commit details
    Browse the repository at this point in the history

  3. Update scripts/exglobal_prep_emissions.py 

    Co-authored-by: David Huber <[email protected]>
    @bbakernoaa @DavidHuber-NOAA
    bbakernoaa and DavidHuber-NOAA authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f204898 View commit details
    Browse the repository at this point in the history

  4. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: David Huber <[email protected]>
    @bbakernoaa @DavidHuber-NOAA
    bbakernoaa and DavidHuber-NOAA authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e7bf48a View commit details
    Browse the repository at this point in the history

  5. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: David Huber <[email protected]>
    @bbakernoaa @DavidHuber-NOAA
    bbakernoaa and DavidHuber-NOAA authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    eab4554 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    71a0547 View commit details
    Browse the repository at this point in the history

  2. Update aero_emissions.py 

    resolving comments
    @bbakernoaa
    bbakernoaa authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d6ce0ab View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    313cb62 View commit details
    Browse the repository at this point in the history

  2. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    438c421 View commit details
    Browse the repository at this point in the history

  3. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8a471fa View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1df78dd View commit details
    Browse the repository at this point in the history

  2. addressing many issues

    @bbakernoaa
    bbakernoaa committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4e660a5 View commit details
    Browse the repository at this point in the history

  3. Adding n_persist to the yaml file and populating that through

    @bbakernoaa
    bbakernoaa committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f4a31bd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c379b5c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'develop' into feature/fire_blending

    @bbakernoaa
    bbakernoaa authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    82a2805 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6d12fb3 View commit details
    Browse the repository at this point in the history

  2. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    934c95f View commit details
    Browse the repository at this point in the history

  3. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    46838fd View commit details
    Browse the repository at this point in the history

  4. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d6e8fc1 View commit details
    Browse the repository at this point in the history

  5. Update ush/python/pygfs/task/aero_emissions.py 

    Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
    @bbakernoaa @WalterKolczynski-NOAA
    bbakernoaa and WalterKolczynski-NOAA authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5039957 View commit details
    Browse the repository at this point in the history