-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an archive task to GEFS system to archive files in HPSS #2895
base: develop
Are you sure you want to change the base?
Add an archive task to GEFS system to archive files in HPSS #2895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some initial suggestions.
…nando-NOAA/global-workflow into feature/gefs-arch-hpss
@EricSinsky-NOAA @WalterKolczynski-NOAA Ready for review. Advice whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggestions based on my testing of a GEFS replay test case.
@EricSinsky-NOAA @WalterKolczynski-NOAA @DavidHuber-NOAA The PR is ready to review. |
{% include "gefs_extracted_atmos.yaml.j2" %} | ||
{% include "gefs_extracted_ocean.yaml.j2" %} | ||
{% include "gefs_extracted_ice.yaml.j2" %} | ||
{% include "gefs_extracted_wave.yaml.j2" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the extracted
? Is this intended to be run only when running with DO_EXTRACTVARS=YES
? If not, then I suggest dropping the _extracted
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are getting close. Just a couple more suggestions.
@EricSinsky-NOAA @DavidHuber-NOAA Made all the suggested changes. If @WalterKolczynski-NOAA agrees with the renaming of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with regard to satisfying the current GEFS reforecast archiving requirements. If one of the GEFS archiving requirements changes, I think this can be addressed in a future PR. Thank you for establishing the GEFS archive task, Anton.
Thanks, Eric. |
Description
Type of change
Change characteristics
How has this been tested?
Checklist