Resolve IC filename mismatch and differentiate model component start date variables #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create specific variables for atmos, ice, mediator, ocean, and wave cycle dates and update scripts/staging yamls to use them. - Also resolve issue with incorrect IC filenames caused by not turning IAU off for cold-start. Refs NOAA-EMC#2865 Refs NOAA-EMC#2890
KateFriedman-NOAA
requested review from
aerorahul,
WalterKolczynski-NOAA and
DavidHuber-NOAA
|
Thanks for your PR @KateFriedman-NOAA |
WalterKolczynski-NOAA
previously approved these changes
Sep 17, 2024
DavidHuber-NOAA
previously approved these changes
Sep 18, 2024
Still trying to resolve the issue. |
- Move DOIAU="NO" to config.stage_ic - Add similar condition check to forecast_predet.sh Refs NOAA-EMC#2865
KateFriedman-NOAA
dismissed stale reviews from DavidHuber-NOAA and WalterKolczynski-NOAA
via
2245e8b
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -91,16 +91,30 @@ | |||
|
|
|||
| # Define model start date for current_cycle and next_cycle as the time the forecast will start | |||
| if [[ "${DOIAU:-NO}" == "YES" ]]; then | |||
| model_start_date_current_cycle="${current_cycle_begin}" | |||
| if [[ "${MODE}" = "cycled" && "${SDATE}" = "${PDY}${cyc}" && ${EXP_WARM_START} = ".false." ]] || [[ "${MODE}" = "forecast-only" && ${EXP_WARM_START} = ".false." ]] ; then | |||
Check notice
Code scanning / shellcheck
Possible misspelling: SDATE may not be assigned. Did you mean CDATE? Note
|
Discussed this with @aerorahul and @WalterKolczynski-NOAA yesterday. Will close this and rework the changes based on our conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves errors reported in issues #2865 and #2890. Upon investigation it was discovered that both issues were caused by the same thing = the IAU not being set to "NO" for cold-start.
DOIAU=YESwas set for the experiment but was not being set to "NO" for the cold-started first half-cycle staging job. Withinconfig.baseis an if-block to sets IAU variables for IAU being off butDOIAUwas not forced to be "NO" and thus the prior "YES" setting was used to define the filenames in the staging job. I addedexport DOIAU="NO"within that if-block to force it off for cold-start.Additionally, to manage the start dates for the various model components better, I created specific variables for atmos, ice, mediator, ocean, and wave cycle dates. Updated fcst scripts and the staging yamls to use them.
FYI @guillaumevernieres @apchoiCMD @jswhit
Resolves #2865
Resolves #2890
Type of change
Change characteristics
How has this been tested?