Support global-workflow using Rocky 8 on CSPs #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…oud into csps-rocky8
…oud into csps-rocky8
…oud into csps-rocky8
weihuang-jedi
requested review from
WalterKolczynski-NOAA,
DavidHuber-NOAA,
aerorahul and
KateFriedman-NOAA
as code owners
|
Show tasks run on different partitions: compute and process |
WalterKolczynski-NOAA
requested changes
Nov 25, 2024
|
This UFS model hash is before the one that introduced the issue with building wave pre/post executables (see #3110), so it should be safe to update. |
DavidHuber-NOAA
requested changes
Nov 27, 2024
workflow/hosts/awspw.yaml
Outdated
| @@ -27,5 +27,5 @@ MAKE_ACFTBUFR: 'NO' | |||
| DO_TRACKER: 'NO' | |||
| DO_GENESIS: 'NO' | |||
| DO_METP: 'NO' | |||
| SUPPORT_WAVES: 'NO' | |||
| SUPPORTED_RESOLUTIONS: ['C48', 'C96'] # TODO: Test and support all cubed-sphere resolutions. | |||
| SUPPORT_WAVES: 'YES' | |||
There was a problem hiding this comment.
Since WW3 will now be supported on all platforms, I think we can remove SUPPORT_WAVES from the host files and setup_expt.py.
Suggested change
| SUPPORT_WAVES: 'YES' |
workflow/hosts/azurepw.yaml
Outdated
| DO_TRACKER: 'NO' | ||
| DO_GENESIS: 'NO' | ||
| DO_METP: 'NO' | ||
| SUPPORT_WAVES: 'YES' |
There was a problem hiding this comment.
Suggested change
| SUPPORT_WAVES: 'YES' |
workflow/hosts/googlepw.yaml
Outdated
| DO_TRACKER: 'NO' | ||
| DO_GENESIS: 'NO' | ||
| DO_METP: 'NO' | ||
| SUPPORT_WAVES: 'YES' |
There was a problem hiding this comment.
Suggested change
| SUPPORT_WAVES: 'YES' |
|
This block global-workflow/workflow/setup_expt.py Lines 374 to 385 in ea07117 Can be simplified to machine = host.machine
for attr in ['resdetatmos', 'resensatmos']:
try:
expt_res = f'C{getattr(inputs, attr)}'
except AttributeError:
continue
if expt_res not in supp_res:
raise NotImplementedError(f"Supported resolutions on {machine} are:\n{', '.join(supp_res)}") |
… all these platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With ParallelWorks now default Rocky 8 on CSPs, and move to Rocky 8 only after 1/1/2025,
we need to modify global-workflow module files to use Rocky 8 supported spack-stack,
and test compile and run to make sure all works under Rocky 8.
i) Rocky 8 update new features:
a. Wave worked in C48_S2SWA_gefs case, so turn SUPPORT_WAVES to "YES" in awspw.yaml.
Actually, if we did not set SUPPORT_WAVES to "YES", setup_expt.py will rise exception.
b. Using two type of nodes (chips/queues) on AWS, compute/process, where forecasts run in "compute" queue,
which is a big node (more cores), others run in "process" queue, which has small node (less cores).
ii) Rocky 8 update needs the following submodules at or newer than the tags below.
commit 4848ecbb5e713b16127433e11f7d3edc6ac784c4 (HEAD, origin/develop, origin/HEAD, develop)
Author: Wei Huang [email protected]
Date: Fri Oct 18 10:41:25 2024 -0600
commit 23237610845c3a4438b21b25e9b3dc25c4c15b73 (HEAD)
Author: Wei Huang [email protected]
Date: Wed Oct 9 11:55:13 2024 -0600
commit 66a422db80ea129dd87285fe6e811d4b6e1fe29b (HEAD)
Author: Wei Huang [email protected]
Date: Wed Oct 2 14:38:22 2024 -0600
commit 29c2703c715ebdb47bbd4bcc811db340eae530e5 (HEAD)
Author: Cameron Book [email protected]
Date: Tue Nov 12 13:08:12 2024 -0800
Resolves #2997
Type of change
Change characteristics
Does this change require a documentation update? YES/NO
How has this been tested?
Checklist