Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gridded wave post #3014

Merged

Conversation

AntonMFernando-NOAA
Copy link
Contributor

Description

The gridded wave post (wavepostsbs) script currently loops over all forecast hours and acts as its own post manager. Other component post and product scripts operate on one forecast time. This PR will update the wave post to match other components, that creates a bunch of short jobs instead of one long job (per member).
Resolves #2290

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Run CI tests in HERA, ORION, and HERCULES

Checklist

  • Gridded wave post scripts that process only one forecast hour specified by the workflow manager (rocoto/ecflow)
  • Rocoto workflow updated to create the corresponding tasks for the new paradigm for both GFS and GEFS
  • Output identical to current system for both GFS and GEFS

@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 26, 2024
@emcbot
Copy link

emcbot commented Nov 26, 2024

CI Passed on Hercules in Build# 3
Built and ran in directory /work2/noaa/global/CI/HERCULES/3014


Experiment C48_ATM_4b0523b0 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 22:54:44 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_4b0523b0 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 23:55:50 CST 2024
Experiment C96_atm3DVar_4b0523b0 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 00:01:20 CST 2024
Experiment C96C48_hybatmDA_4b0523b0 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 00:07:32 CST 2024
Experiment C48_S2SW_4b0523b0 Completed 2 Cycles: *SUCCESS* at Tue Nov 26 00:32:03 CST 2024
Experiment C48_S2SWA_gefs_4b0523b0 Completed 1 Cycles: *SUCCESS* at Tue Nov 26 02:52:29 CST 2024

@AntonMFernando-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA @DavidHuber-NOAA I think all good now.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Nov 26, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Nov 26, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Nov 26, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3014/RUNTESTS on WCOSS

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Nov 26, 2024
@AntonMFernando-NOAA AntonMFernando-NOAA self-assigned this Nov 26, 2024
@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 26, 2024
@emcbot
Copy link

emcbot commented Nov 26, 2024

CI Passed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI_dh/3014


Experiment C48_ATM_232027f8 Completed 2 Cycles: *SUCCESS* at Tue Nov 26 19:52:38 UTC 2024
Experiment C48mx500_3DVarAOWCDA_232027f8 Completed 2 Cycles: *SUCCESS* at Tue Nov 26 20:16:59 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_232027f8 Completed 1 Cycles: *SUCCESS* at Tue Nov 26 20:48:26 UTC 2024
Experiment C96C48_hybatmaerosnowDA_232027f8 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 21:48:52 UTC 2024
Experiment C96_atm3DVar_232027f8 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 21:54:57 UTC 2024
Experiment C96C48_hybatmDA_232027f8 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 21:54:58 UTC 2024
Experiment C48_S2SW_232027f8 Completed 2 Cycles: *SUCCESS* at Tue Nov 26 22:20:26 UTC 2024
Experiment C96C48_ufs_hybatmDA_232027f8 Completed 3 Cycles: *SUCCESS* at Tue Nov 26 22:37:31 UTC 2024
Experiment C48_S2SWA_gefs_232027f8 Completed 1 Cycles: *SUCCESS* at Tue Nov 26 23:06:46 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Nov 27, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 94f2029 into NOAA-EMC:develop Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor gridded wave post to match other components
10 participants