-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gridded wave post #3014
Merged
WalterKolczynski-NOAA
merged 140 commits into
NOAA-EMC:develop
from
AntonMFernando-NOAA:feature/wave_post_grid
Nov 27, 2024
Merged
Refactor gridded wave post #3014
WalterKolczynski-NOAA
merged 140 commits into
NOAA-EMC:develop
from
AntonMFernando-NOAA:feature/wave_post_grid
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonMFernando-NOAA
requested review from
JessicaMeixner-NOAA,
sbanihash and
WalterKolczynski-NOAA
as code owners
October 21, 2024 19:54
emcbot
added
CI-Hercules-Building
**Bot use only** CI testing is cloning/building on Hercules
CI-Hercules-Running
**Bot use only** CI testing on Hercules for this PR is in-progress
CI-Hercules-Passed
**Bot use only** CI testing on Hercules for this PR has completed successfully
and removed
CI-Hercules-Ready
**CM use only** PR is ready for CI testing on Hercules
CI-Hercules-Building
**Bot use only** CI testing is cloning/building on Hercules
CI-Hercules-Running
**Bot use only** CI testing on Hercules for this PR is in-progress
labels
Nov 26, 2024
CI Passed on Hercules in Build# 3
|
@WalterKolczynski-NOAA @DavidHuber-NOAA I think all good now. |
WalterKolczynski-NOAA
added
CI-Hera-Ready
**CM use only** PR is ready for CI testing on Hera
CI-Wcoss2-Building
**Bot use only** CI testing is cloning/building on WCOSS
labels
Nov 26, 2024
WalterKolczynski-NOAA
approved these changes
Nov 26, 2024
emcbot
added
CI-Hera-Building
**Bot use only** CI testing is cloning/building on Hera
and removed
CI-Hera-Ready
**CM use only** PR is ready for CI testing on Hera
labels
Nov 26, 2024
WalterKolczynski-NOAA
added
CI-Wcoss2-Running
**Bot use only** CI testing on WCOSS for this PR is in-progress
and removed
CI-Wcoss2-Building
**Bot use only** CI testing is cloning/building on WCOSS
labels
Nov 26, 2024
CI Tests set up to run in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_3014/RUNTESTS on WCOSS |
emcbot
added
CI-Hera-Running
**Bot use only** CI testing on Hera for this PR is in-progress
and removed
CI-Hera-Building
**Bot use only** CI testing is cloning/building on Hera
labels
Nov 26, 2024
emcbot
added
CI-Hera-Passed
**Bot use only** CI testing on Hera for this PR has completed successfully
and removed
CI-Hera-Running
**Bot use only** CI testing on Hera for this PR is in-progress
labels
Nov 26, 2024
CI Passed on Hera in Build# 4
|
WalterKolczynski-NOAA
added
CI-Wcoss2-Passed
**Bot use only** CI testing on WCOSS for this PR has completed successfully
and removed
CI-Wcoss2-Running
**Bot use only** CI testing on WCOSS for this PR is in-progress
labels
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-Hera-Passed
**Bot use only** CI testing on Hera for this PR has completed successfully
CI-Hercules-Passed
**Bot use only** CI testing on Hercules for this PR has completed successfully
CI-Wcoss2-Passed
**Bot use only** CI testing on WCOSS for this PR has completed successfully
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gridded wave post (wavepostsbs) script currently loops over all forecast hours and acts as its own post manager. Other component post and product scripts operate on one forecast time. This PR will update the wave post to match other components, that creates a bunch of short jobs instead of one long job (per member).
Resolves #2290
Type of change
Change characteristics
How has this been tested?
Checklist