Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI jekninsfile update hotfix #3038

Merged
merged 15 commits into from
Oct 28, 2024
Merged

CI jekninsfile update hotfix #3038

merged 15 commits into from
Oct 28, 2024

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Oct 27, 2024 •
edited
Loading

Description

This PR is a needed hotfix to the Jenkinsfile pipeline script that fixes a bug with the matrix control variable name clash with the variable system for the two build types.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)

How has this been tested?

Ran end-to-end in a CI self-test PR here

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@TerryMcGuinness-NOAA
removed catchError to see error with get_host_case_list script (also …
b25f382 
…skips build)
@TerryMcGuinness-NOAA
catchError is still being applied, but did fail, adding source gwsetu…
31fa9be 
…p for second test
@TerryMcGuinness-NOAA
drilling down on real error that is acctually in create experment (me…
688e1ba 
… thinks it is env.HOME_GFS update)
@TerryMcGuinness-NOAA
system is a matrix control variable and could not be resloved in shel…
39c644b 
…l environment (bug)
@TerryMcGuinness-NOAA
removed HOME_GFS where was using system which is a matrix control var…
9b3c6e6 
…iable and not resolved in bash environment
@TerryMcGuinness-NOAA
.system not found in readYaml object and is not even used
cf6b48e
@TerryMcGuinness-NOAA
drilling down to error with system that looks like write to disk problem
f32df3e
@TerryMcGuinness-NOAA
fixed issue with system name clash issue
e115db5
@TerryMcGuinness-NOAA
fixed issue with system name clash issue and put build back in for fi…
df34b7d 
…nal test
@TerryMcGuinness-NOAA
took out extra source on gwsetup as was not the issue
8acaa62
@TerryMcGuinness-NOAA
failed again when running run script, wtf
4dc4b04
@TerryMcGuinness-NOAA
put create experment back
24b02e9
@TerryMcGuinness-NOAA
just adding more output for finding more info on sytem fail
ae2170a
@TerryMcGuinness-NOAA
finaly found bug, system was no login in matrix when added refined pa…
02c7682 
…rallel structure so got it back from tmp yaml files in next step
@TerryMcGuinness-NOAA
put build back in to after fixing system variable bug
7c75021
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI/CD Issue related to CI/CD labels Oct 27, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Oct 27, 2024
@emcbot
Copy link

emcbot commented Oct 27, 2024

CI Passed on Orion in Build# 1
Built and ran in directory /work2/noaa/stmp/CI/ORION/3038


Experiment C96_S2SWA_gefs_replay_ics_7c750218 Completed 1 Cycles: *SUCCESS* at Sun Oct 27 10:50:27 AM CDT 2024
Experiment C48_ATM_7c750218 Completed 2 Cycles: *SUCCESS* at Sun Oct 27 10:56:25 AM CDT 2024
Experiment C96_atm3DVar_7c750218 Completed 3 Cycles: *SUCCESS* at Sun Oct 27 12:27:47 PM CDT 2024
Experiment C96C48_hybatmDA_7c750218 Completed 3 Cycles: *SUCCESS* at Sun Oct 27 12:34:14 PM CDT 2024
Experiment C48_S2SWA_gefs_7c750218 Completed 1 Cycles: *SUCCESS* at Sun Oct 27 12:35:54 PM CDT 2024
Experiment C48_S2SW_7c750218 Completed 2 Cycles: *SUCCESS* at Sun Oct 27 12:52:13 PM CDT 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit b56f633 into NOAA-EMC:develop Oct 28, 2024
21 of 22 checks passed
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA deleted the hotfix/ci_jekninsfile_update branch November 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA

Labels
CI/CD Issue related to CI/CD CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TerrenceMcGuinness-NOAA @emcbot @WalterKolczynski-NOAA @TerryMcGuinness-NOAA