Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GFS version to v16.3.22 #3095

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR updates the version for the "WAFS removal from GFS" release branch to v16.3.22.

Refs #2591

@KateFriedman-NOAA
Copy link
Member Author

FYI @YaliMao-NOAA

@KateFriedman-NOAA KateFriedman-NOAA merged commit 9861ce0 into NOAA-EMC:release/gfs.v16.3.22 Nov 13, 2024
1 check failed
@KateFriedman-NOAA KateFriedman-NOAA deleted the release/gfs.v16.3.22 branch November 13, 2024 19:14
@YaliMao-NOAA
Copy link
Contributor

@KateFriedman-NOAA Other than WAFS related script removal from GFS, UPP script needs to be modified and stop generating WAFS UPP products.
Should it be done in global-workflow or in UPP?
Thank you!

@KateFriedman-NOAA
Copy link
Member Author

@YaliMao-NOAA In GFSv16 the UPP still owns all of its scripts so everything from the JJOB script level down is in the UPP tag for GFSv16. Therefore, we'll need an updated UPP tag that has removed the WAFS product generation. We'll then need to update the UPP tag in the workflow release branch, cut a new hand-off tag, and let NCO know.

Tagging @HuiyaChuang-NOAA for awareness.

@YaliMao-NOAA
Copy link
Contributor

@KateFriedman-NOAA Thank you. I will make a PR to UPP based on upp_v8.3.0 which is used by gfs.v16.3.22. You are expecting a new tag upp_v8.3.1 for it.

Tagging @WenMeng-NOAA for awareness

@KateFriedman-NOAA
Copy link
Member Author

Sounds good, thanks @YaliMao-NOAA ! Thanks also for tagging Wen!

@YaliMao-NOAA
Copy link
Contributor

@KateFriedman-NOAA Sorry I overlooked the fact that global-workflow has already stopped WAFS products from global-workflow by removing 'WAFSF' definition. So for WAFS separation from GFSv16.3, no new UPP tag is needed.
Sorry for the confusion!
@WenMeng-NOAA

@KateFriedman-NOAA
Copy link
Member Author

@WenMeng-NOAA No worries, thanks for confirming! Not gonna complain about less work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants