Separate use of initial increment/perturbation file from REPLAY/+03 ICs #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes. Lines starting
…lobal-workflow into gefs_replay_ci
Fix a bug in a variable check in the extractvars task where parenthesis in the variable name will prompt a false warning message.
Ice variables are extracted from the history files instead of the product files. This is necessary because there are certain ice variables that are needed that are only available in the history files and not the product files.
Add suggested patches to gefs_replay_ci
Shellcheck disable has been added. Also, f000 is skipped in extractvars for ocn and ice since there are no products for f000 for ocn and ice. This change will remove warning messages.
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
from REPLAY 03 files
NeilBarton-NOAA
requested review from
WalterKolczynski-NOAA,
aerorahul,
junwang-noaa,
KateFriedman-NOAA,
DavidHuber-NOAA and
TerrenceMcGuinness-NOAA
as code owners
Comment on lines
-15
to
-18
| cdate="${PDY}${cyc}" | ||
| if (( cdate < 2017072000 )); then | ||
| export NST_SPINUP=1 | ||
| fi |
There was a problem hiding this comment.
Curious why this is being removed? No longer need?
| cdate="${PDY}${cyc}" | ||
| if (( cdate < 2017072000 )); then | ||
| export NST_SPINUP=1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
We should probably still include NST_SPINUP, but set it to 0.
Suggested change
| export NST_SPINUP=0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of the previous SFS PR. The use of initial perturbations/increments for ensemble long forecasts (e.g., SFS and GEFS) was missing from the previous PR because this option was included with the REPLAY_IC option.
In this PR, the REPLAY_IC option is now strictly for the +03 ICs, and the variables USE_ATM_ENS_PERTURB_FILES and USE_OCN_ENS_PERTURB_FILES are used for initialization with the initial perturbation/increment files used for SFS and GEFS reforecasting. This separation will also make it easier to remove the +03 IC optoin.
Type of change
Change characteristics
How has this been tested?
I tested long forecast runs on hercules and multiple CI tests.
Checklist