Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust configuration for reforecast #3123

Merged

Conversation

EricSinsky-NOAA
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA commented Nov 25, 2024

Description

This PR does the following for the GEFS reforecast:

  • Archive ensemble spread in addition to ensemble mean
  • Set NST_SPINUP to 0 for all 30 years
  • Remove arcdir from arch task since it is only used in the extractvars task
  • Change the repair job dependency to a forecast task dependency for each member instead of a file dependency
  • Remove the experiment name (PSLOT) from the ARCDIR directory structure for the reforecast
  • Adjust ensemble header information in forecast_predet so that any ensemble size can be used
  • Remove wave post pnt dependency from archive task

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@EricSinsky-NOAA EricSinsky-NOAA changed the title Removearcdir Adjust configuration for reforecast Nov 25, 2024
Removing PSLOT from the ARCDIR directory structure is preferred for the reforecast, particularly for reforecast data saved on WCOSS2.
The ensemble header information has been modified so that the ensemble information is correct for any ensemble size.
@EricSinsky-NOAA EricSinsky-NOAA marked this pull request as ready for review November 29, 2024 12:33
@EricSinsky-NOAA EricSinsky-NOAA merged commit 40f4536 into NOAA-EMC:feature/gefs_reforecast Nov 29, 2024
5 checks passed
@EricSinsky-NOAA EricSinsky-NOAA deleted the removearcdir branch February 12, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants