Skip to content

GCAFS prep emissions update - fire emissions #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

GCAFS prep emissions update - fire emissions #3713

wants to merge 3 commits into from

Conversation

bbakernoaa
Copy link
Contributor

Description

This pull request introduces significant updates to the aerosol configuration and emission handling in the UFS-Aerosols system, streamlining file management, improving modularity, and consolidating configuration files. Key changes include restructuring aerosol configuration files, enhancing biomass burning emissions handling, and updating the chemical input file linking process.

Aerosol Configuration Updates:

  • Refactored config.aero.j2 to organize settings into distinct sections for aerosol and emission configurations, including the addition of new variables like AERO_EMIS_FIRE_VERSION and AERO_EMIS_FIRE_HIST. [1] [2]

Emission Data Management:

  • Consolidated multiple emission configuration files (ExtData.gbbepx, ExtData.qfed, and ExtData.none) into a single file, AERO_ExtData.rc, for better modularity and maintainability. Removed redundant and unused emission entries. [1] [2] [3] [4]

Chemical Input File Handling:

  • Added linking of chemical input files (CHEM_INPUT) in forecast_predet.sh to ensure proper file availability during runtime.

Removal of Legacy Code:

  • Removed the automated generation of AERO_ExtData.rc in parsing_namelists_GOCART.sh, as the new consolidated configuration file eliminates the need for dynamic generation.

Additional Updates:

  • Updated config.com to include new template paths for chemical restart and input files, improving file organization.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • Forecast-only on hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@bbakernoaa
Refactor aerosol emissions processing by removing obsolete ExtData fi…
75162e6 
…les and enhancing QFED and GBBEPx handling

- Deleted outdated ExtData configuration files for GBBEPx, NONE, and QFED emissions.
- Updated `forecast_predet.sh` to link chemical input files for GOCART.
- Removed automatic generation of ExtData configuration in `parsing_namelists_GOCART.sh`.
- Enhanced `aero_emissions.py` to improve handling of historical and forecast emissions, including better logging and error handling.
- Implemented robust file searching for GBBEPx and QFED emissions, including support for multiple file patterns and improved directory checks.
- Added functionality to combine multiple QFED files into a single NetCDF file with proper variable renaming and attribute management.
- Updated the execution flow to ensure processed files are correctly tracked and logged.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 20, 2025
View reviewed changes
dev/parm/config/gcafs/config.aero.j2
#================================================================================
# 1. Aerosol settings
#================================================================================
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}

Check warning

Code scanning / shellcheck

This { is literal. Check expression (missing ;/\n?) or quote it. Warning

This { is literal. Check expression (missing ;/\n?) or quote it.
dev/parm/config/gcafs/config.aero.j2
#================================================================================
# 1. Aerosol settings
#================================================================================
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}

Check warning

Code scanning / shellcheck

This { is literal. Check expression (missing ;/\n?) or quote it. Warning

This { is literal. Check expression (missing ;/\n?) or quote it.
dev/parm/config/gcafs/config.aero.j2
#================================================================================
# 1. Aerosol settings
#================================================================================
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}

Check warning

Code scanning / shellcheck

This } is literal. Check expression (missing ;/\n?) or quote it. Warning

This } is literal. Check expression (missing ;/\n?) or quote it.
dev/parm/config/gcafs/config.aero.j2
#================================================================================
# 1. Aerosol settings
#================================================================================
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}

Check warning

Code scanning / shellcheck

This } is literal. Check expression (missing ;/\n?) or quote it. Warning

This } is literal. Check expression (missing ;/\n?) or quote it.
@CoryMartin-NOAA CoryMartin-NOAA requested a review from Copilot May 20, 2025 20:40
Copilot
Copilot AI reviewed May 20, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates aerosol configuration and emissions handling for the UFS-Aerosols system by consolidating file management and enhancing modularity. Key changes include:

  • Removing legacy logic for generating the AERO_ExtData.rc file and consolidating emission configuration files.
  • Adding a link to chemical input files in forecast_predet.sh and updating configuration templates in both aerosol and chemical configuration files.
  • Refactoring configuration files to improve clarity and maintainability.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ush/parsing_namelists_GOCART.sh Removed legacy dynamic generation of AERO_ExtData.rc.
ush/forecast_predet.sh Added linking for CHEM_INPUT to ensure chemical input file availability.
parm/ufs/gocart/ExtData.* Removed obsolete emission configuration files, consolidating them into AERO_ExtData.rc.
parm/ufs/gocart/AERO_ExtData.rc Updated emission entries to use chemical input paths and adjusted emission factors.
parm/chem/chem_emission.yaml.j2 Updated templating loops for QFED variables and file copying operations.
dev/parm/config/gfs/config.com Added new chemical template paths.
dev/parm/config/gcafs/config.aero.j2 Reorganized aerosol sections and introduced new aerosol emission settings.

dev/parm/config/gcafs/config.aero.j2
#================================================================================
# 1. Aerosol settings
#================================================================================
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}
Copy link
Preview

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider enclosing the AERO_INPUTS_DIR value in quotes to prevent potential word splitting or globbing issues if the path contains spaces.

Suggested change
export AERO_INPUTS_DIR={{ AERO_INPUTS_DIR }}
export AERO_INPUTS_DIR="{{ AERO_INPUTS_DIR }}"

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

@lipan-NOAA lipan-NOAA Awaiting requested review from lipan-NOAA

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul will be requested when the pull request is marked ready for review aerorahul is a code owner

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA will be requested when the pull request is marked ready for review WalterKolczynski-NOAA is a code owner

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA will be requested when the pull request is marked ready for review TerrenceMcGuinness-NOAA is a code owner

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA will be requested when the pull request is marked ready for review DavidHuber-NOAA is a code owner

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA KateFriedman-NOAA will be requested when the pull request is marked ready for review KateFriedman-NOAA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bbakernoaa