Replace `NDATE` with `date` #3725

KateFriedman-NOAA · 2025-05-22T18:58:04Z

Description

This PR replaces instances of the NDATE utility with the date command in the workflow. Included is some cleanup of CDATE instances (replaced with PDYcyc) and replacing some cut commands that I came across while removing NDATE.

Resolves #3699

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? NO

How has this been tested?

Ran CI suite on WCOSS2.

Checklist

Refs NOAA-EMC#3699

- Also update date commands in some JJOB scripts Refs NOAA-EMC#3699

Refs NOAA-EMC#3699

jobs/JGDAS_ATMOS_ANALYSIS_DIAG

jobs/JGDAS_ENKF_DIAG

jobs/JGDAS_ENKF_ECEN

jobs/JGDAS_ENKF_SELECT_OBS

jobs/JGDAS_ENKF_SFC

jobs/JGDAS_ENKF_UPDATE

jobs/JGLOBAL_ATMOS_ANALYSIS_CALC

jobs/JGLOBAL_OFFLINE_ATMOS_ANALYSIS

scripts/exgdas_atmos_chgres_forenkf.sh

scripts/exglobal_atmos_analysis.sh

JessicaMeixner-NOAA

The wave related codes look okay to me.

- Add shellcheck disable of SC2153 back into scripts Refs NOAA-EMC#3699

Refs NOAA-EMC#3699

scripts/exgfs_wave_prep.sh

scripts/exglobal_atmos_tropcy_qc_reloc.sh

ush/tropcy_relocate_extrkr.sh

ush/tropcy_relocate.sh

Remove starting message Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

Refs NOAA-EMC#3699

KateFriedman-NOAA · 2025-05-23T14:11:46Z

Rerunning tests on WCOSS2 after syncing with develop and addressing reviewer comments.

KateFriedman-NOAA · 2025-05-29T17:02:24Z

Restarting CI on WCOSS2, kicked it off on wrong (prod) side.

emcbot · 2025-05-29T17:29:54Z

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3725/RUNTESTS on WCOSS

KateFriedman-NOAA · 2025-05-29T19:47:42Z

WCOSS2 CI was partially complete before a sudden production switch happened and killed the tests:

Thu May 29 19:40:04 UTC 2025
******** C48_ATM_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 29 2025 17:29:57    May 29 2025 18:26:25

******** C48mx500_3DVarAOWCDA_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 29 2025 17:29:58    May 29 2025 17:46:32
202103250000        Done    May 29 2025 17:29:58    May 29 2025 19:35:57

******** C48mx500_hybAOWCDA_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    May 29 2025 17:30:00    May 29 2025 17:46:41
202103250000        Done    May 29 2025 17:30:00    May 29 2025 18:56:27

******** C48_S2SW_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 29 2025 17:30:02    May 29 2025 18:36:33

******** C48_S2SWA_gefs_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    May 29 2025 17:30:04    May 29 2025 18:36:39

******** C48_S2SW_extended_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200      Active    May 29 2025 17:30:07             -          
202103231800      Active    May 29 2025 17:30:07             -          

******** C96_atm3DVar_extended_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 29 2025 17:30:10    May 29 2025 17:47:06
202112210000      Active    May 29 2025 17:30:10             -          
202112210600      Active    May 29 2025 17:30:10             -          
202112211200      Active    May 29 2025 17:52:07             -          
202112211800    Inactive             -                       -          

******** C96C48_hybatmaerosnowDA_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 29 2025 17:30:12    May 29 2025 17:52:13
202112201800      Active    May 29 2025 17:30:12             -          
202112210000      Active    May 29 2025 17:30:12             -          

******** C96C48_hybatmDA_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    May 29 2025 17:30:14    May 29 2025 17:47:14
202112210000      Active    May 29 2025 17:30:14             -          
202112210600      Active    May 29 2025 17:30:14             -          

******** C96C48mx500_S2SW_cyc_gfs_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    May 29 2025 17:30:16    May 29 2025 17:47:19
202112201800      Active    May 29 2025 17:30:16             -          
202112210000      Active    May 29 2025 17:30:16             -          
202112211800      Active    May 29 2025 17:52:21             -          

******** C96C48_ufs_hybatmDA_3725 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    May 29 2025 17:30:18    May 29 2025 17:47:25
202402240000      Active    May 29 2025 17:30:18             -          
202402240600      Active    May 29 2025 17:30:18             -          

******** C96mx100_S2S_3725 ********
199405010000    sfs_atmos_ensstat_f144    druby://clogin03.cactus.wcoss2.ncep.noaa.gov:42871          SUBMITTING                   -         0           0.0

KateFriedman-NOAA · 2025-05-29T20:26:41Z

Setting WCOSS2 CI to "passed" since enough of the tests ran to invoke the changes in this PR. Will further rely on the CI tests running on Hercules.

aerorahul

lgtm

emcbot · 2025-05-29T21:06:47Z

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3725/RUNTESTS/COMROOT/C96C48_hybatmDA_2d06ca74/logs/2021122100/gdas_verfozn.log

Follow link here to view the contents of the above file(s): (gdas_verfozn.log)

emcbot · 2025-05-29T21:06:49Z

Experiment C48mx500_hybAOWCDA FAILED on Hercules in Build# 1 with error logs:

Follow link here to view the contents of the above file(s):

emcbot · 2025-05-29T21:06:50Z

Experiment C96_atm3DVar FAILED on Hercules in Build# 1 with error logs:

Follow link here to view the contents of the above file(s):

emcbot · 2025-05-29T21:06:57Z

Experiment C48mx500_hybAOWCDA FAILED on Hercules in Build# 1 in
/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3725/RUNTESTS/EXPDIR/C48mx500_hybAOWCDA_2d06ca74

emcbot · 2025-05-29T21:06:58Z

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 in
/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3725/RUNTESTS/EXPDIR/C96C48_hybatmDA_2d06ca74

emcbot · 2025-05-29T21:06:58Z

Experiment C96_atm3DVar FAILED on Hercules in Build# 1 in
/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3725/RUNTESTS/EXPDIR/C96_atm3DVar_2d06ca74

KateFriedman-NOAA added 3 commits May 22, 2025 16:16

Replace NDATE with data in JJOB scripts

61b3c4a

Refs NOAA-EMC#3699

Replace NDATE with date in scripts and ush

2a07da8

- Also update date commands in some JJOB scripts Refs NOAA-EMC#3699

Add space to date command in exgfs_wave_prep.sh

acb7906

Refs NOAA-EMC#3699

KateFriedman-NOAA requested review from JessicaMeixner-NOAA, sbanihash, JiayiPeng-NOAA, WalterKolczynski-NOAA, RussTreadon-NOAA, CoryMartin-NOAA, CatherineThomas-NOAA and jack-woollen as code owners May 22, 2025 18:58

github-advanced-security bot found potential problems May 22, 2025

View reviewed changes

JessicaMeixner-NOAA previously approved these changes May 22, 2025

View reviewed changes

Address shellcheck warnings

3874f12

- Add shellcheck disable of SC2153 back into scripts Refs NOAA-EMC#3699

KateFriedman-NOAA dismissed JessicaMeixner-NOAA’s stale review via 3874f12 May 22, 2025 19:13

Change a PDY back to date in exgfs_wave_prep.sh

90b699a

Refs NOAA-EMC#3699

aerorahul reviewed May 22, 2025

View reviewed changes

scripts/exgfs_wave_prep.sh Outdated Show resolved Hide resolved

aerorahul reviewed May 22, 2025

View reviewed changes

scripts/exglobal_atmos_tropcy_qc_reloc.sh Outdated Show resolved Hide resolved

aerorahul reviewed May 22, 2025

View reviewed changes

scripts/exglobal_atmos_tropcy_qc_reloc.sh Outdated Show resolved Hide resolved

aerorahul reviewed May 22, 2025

View reviewed changes

ush/tropcy_relocate_extrkr.sh Outdated Show resolved Hide resolved

CoryMartin-NOAA previously approved these changes May 22, 2025

View reviewed changes

aerorahul reviewed May 23, 2025

View reviewed changes

ush/tropcy_relocate.sh Outdated Show resolved Hide resolved

Update scripts/exgfs_wave_prep.sh

ed1bef0

Remove starting message Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

KateFriedman-NOAA dismissed CoryMartin-NOAA’s stale review via ed1bef0 May 23, 2025 13:51

KateFriedman-NOAA and others added 5 commits May 23, 2025 09:52

Update scripts/exglobal_atmos_tropcy_qc_reloc.sh

709e6b3

Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

Update scripts/exglobal_atmos_tropcy_qc_reloc.sh

632a683

Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

Update ush/tropcy_relocate.sh

3df4949

Refs NOAA-EMC#3699 Co-authored-by: Rahul Mahajan <[email protected]>

Correct date slicing commands

965d0b2

Refs NOAA-EMC#3699

Merge branch 'NOAA-EMC:develop' into feature/replace_ndate_w_date

84fabb2

emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels May 29, 2025

KateFriedman-NOAA added CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels May 29, 2025

KateFriedman-NOAA added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS and removed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed labels May 29, 2025

KateFriedman-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels May 29, 2025

aerorahul self-requested a review May 29, 2025 20:48

aerorahul approved these changes May 29, 2025

View reviewed changes

emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels May 29, 2025

emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels May 30, 2025

Replace NDATE with date #3725

Are you sure you want to change the base?

Replace NDATE with date #3725

Uh oh!

Conversation

KateFriedman-NOAA commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KateFriedman-NOAA commented May 23, 2025

Uh oh!

KateFriedman-NOAA commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

KateFriedman-NOAA commented May 29, 2025

Uh oh!

KateFriedman-NOAA commented May 29, 2025

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

emcbot commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

emcbot commented May 29, 2025

Uh oh!

Uh oh!

Replace `NDATE` with `date` #3725

Replace `NDATE` with `date` #3725

KateFriedman-NOAA commented May 22, 2025 •

edited

Loading