Skip to content

Add cice analysis restart to ocean analysis archiving #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add cice analysis restart to ocean analysis archiving #3730

wants to merge 3 commits into from
+6 −1

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented May 25, 2025 •
edited
Loading

Description

Adds cice analysis restart to ocean analysis archiving to complete marine DA archiving.

Resolves NOAA-EMC/GDASApp#1691

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Completed C96C48mx500_S2SW_cyc_gfs on Hera, and checked for file on HPSS

EXPDIR: /scratch1/NCEPDEV/da/Andrew.Eichmann/fv3gfs/ice-restart/test/EXPDIR
COMROOT: /scratch1/NCEPDEV/stmp4/Andrew.Eichmann/COMROOT/arch-cice-anl-rst

Second archived file here:

[Andrew.Eichmann@hfe09 testarchive]$ htar -tvf /1year/NCEPDEV/emc-global/Andrew.Eichmann/HERA/scratch/arch-cice-anl-rst/2021122100/gdasocean_analysis.tar 
[connecting to hpsscore1.fairmont.rdhpcs.noaa.gov/1217]
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    2585207 2025-05-24 18:49  gdas.20211221/00/analysis/ocean/gdas.t00z.ocninc.nc                       
**HTAR: -rw-r--r--  Andrew.Eichmann/stmp    3208512 2025-05-24 18:49 gdas.20211221/00/analysis/ice/20211220.210000.cice_model_anl.res.nc**
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    1056675 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/gdas.t00z.ocn.incr.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    1565229 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/gdas.t00z.ocn.ana.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp      87158 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/gdas.t00z.ice.incr.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp     162311 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/gdas.t00z.ice.ana.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    2609089 2025-05-24 18:21  gdas.20211221/00/bmatrix/ocean/gdas.t00z.ocean.bkgerr_ens_stddev.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp      87161 2025-05-24 18:21  gdas.20211221/00/bmatrix/ice/gdas.t00z.ice.bkgerr_ens_stddev.nc
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp         54 2025-05-24 18:49  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sss_smos_l2.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        433 2025-05-24 18:49  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sss_smap_l2.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        357 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sst_abi_g17_l3c.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        970 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sst_viirs_npp_l3u.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        366 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.icec_amsr2_south.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        915 2025-05-24 18:49  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.adt_rads_all.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        676 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.icec_amsr2_north.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        580 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sst_abi_g16_l3c.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        965 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sst_viirs_n20_l3u.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        963 2025-05-24 18:50  gdas.20211221/00/analysis/ocean/diags/gdas.t00z.ocn.sst_avhrr_mb_l3u.stats.csv
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   40066133 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/adt_rads_all.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   40332304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/icec_amsr2_south.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    9936718 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sst_viirs_npp_l3u.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    5372304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sss_smap_l2.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   18292304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sst_abi_g16_l3c.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   40332304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/icec_amsr2_north.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   29692304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sss_smos_l2.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    8416718 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sst_avhrr_mb_l3u.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp   22092304 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sst_abi_g17_l3c.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp    9936718 2025-05-24 18:31  gdas.20211221/00/analysis/ocean/diags/sst_viirs_n20_l3u.2021122100.nc4
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp       1669 2025-05-24 18:26  gdas.20211221/00/analysis/ocean/yaml/soca_2cice_global.yaml
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp        760 2025-05-24 18:26  gdas.20211221/00/analysis/ocean/yaml/socaincr2mom6.yaml
HTAR: -rw-r--r--  Andrew.Eichmann/stmp        873 2025-05-24 12:06  gdas.20211221/00/analysis/ocean/yaml/obsop_name_map.yaml
HTAR: -rw-r--r--  Andrew.Eichmann/stmp       8679 2025-05-24 12:06  gdas.20211221/00/analysis/ocean/yaml/fields_metadata.yaml
HTAR: -rw-rw-r--  Andrew.Eichmann/stmp       5999 2025-05-24 18:26  gdas.20211221/00/analysis/ocean/yaml/soca_diag_stats.yaml
HTAR: -rw-------  Andrew.Eichmann/da        256 2025-05-24 21:02  /tmp/HTAR_CF_CHK_4018571_1748120525
HTAR: Listing complete for /1year/NCEPDEV/emc-global/Andrew.Eichmann/HERA/scratch/arch-cice-anl-rst/2021122100/gdasocean_analysis.tar, 34 files 34 total objects
HTAR: HTAR SUCCESSFUL

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review May 25, 2025 12:40
@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @KatherineLukens-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request May 25, 2025
Open
DavidHuber-NOAA
DavidHuber-NOAA reviewed May 27, 2025
View reviewed changes
@AndrewEichmann-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA Testing with DOIAU=NO kicked over a rotten log of places where this case is neglected in marine DA archiving, so evidently the CI doesn't touch it. Can we make that a separate issue from this file?

@DavidHuber-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA Sure, I'm fine with that. Please open another issue and I'll re-review. Could you also add a note to gdas_oceananalysis.yaml.j2 that this has not been tested with DOIAU=NO?

shlyaeva
shlyaeva approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but code changes look good to me!

DavidHuber-NOAA
DavidHuber-NOAA approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DavidHuber-NOAA
Copy link
Contributor

Launching CI on C6.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label May 29, 2025
@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request May 29, 2025
Open
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label May 29, 2025
@AndrewEichmann-NOAA
Copy link
Contributor Author

Issue #3742 opened

@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Gaeac6-Running CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels May 29, 2025
@aerorahul aerorahul linked an issue May 29, 2025 that may be closed by this pull request
Archiving tasks fail on Marine DA files when DOIAU=NO #3742
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlyaeva shlyaeva shlyaeva approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees
No one assigned
Labels
CI-Gaeac6-Running CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archiving tasks fail on Marine DA files when DOIAU=NO CICE analysis restart not archived
4 participants
@AndrewEichmann-NOAA @DavidHuber-NOAA @shlyaeva @emcbot