Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mask to edge of domain in smoke preprocessing #556

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

LiamWedell-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • Fix to emissions artifacts on boundaries of domain.
  • Add mask to smoke preprocessing

TESTS CONDUCTED:

Tests are currently taking place

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

  • Fixes the issue(s) mentioned in #9999

CONTRIBUTORS (optional):

@JohanaRomeroAlvarez

@ShunLiu-NOAA
Copy link
Contributor

Do you have any test result related to this PR?

@JohanaRomeroAlvarez
Copy link
Contributor

JohanaRomeroAlvarez commented Nov 27, 2024

@ShunLiu-NOAA,
Yes, we tested this on both Hera and WCOSS2. Below are a couple of plots highlighting the emission rates without and with the mask applied. These plots demonstrate how the mask resolves the issue at the edges without affecting other points.

Screenshot 2024-11-27 at 5 13 01 PM

Screenshot 2024-11-27 at 5 20 34 PM

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit e9995a5 into NOAA-EMC:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants