Make the ic task dependency for prep_ic be optional based on the DO_IC_LBC setting
#804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqing-noaa
requested review from
MatthewPyle-NOAA,
ShunLiu-NOAA,
JacobCarley-NOAA and
BenjaminBlake-NOAA
as code owners
guoqing-noaa
requested review from
chunhuazhou,
HuiLiu-NOAA,
HaidaoLin-NOAA,
spanNOAA,
Junjun-NOAA and
SamuelDegelia-NOAA
HaidaoLin-NOAA
approved these changes
May 24, 2025
|
Thanks @guoqing-noaa for making this change quickly! |
Junjun-NOAA
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #746 added the granularity to run a customized set of workflow tasks for different experiments.
One can run one copy of ioda/ic/lbc tasks and use it for multiple DA/NWP experiments.
Under this situation, the
prep_icwill NOT depend on theictask, as IODA/IC/LBC files have already been pre-generated.We have dropped that ic dependency for pure forecasts if
DO_IC_LBC=falseThis PR applies this logic to the cycling DA experiments.