-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hsi #21
Closed
Closed
Feature/hsi #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 50.88% 48.10% -2.78%
===========================================
Files 16 18 +2
Lines 1476 1609 +133
Branches 313 336 +23
===========================================
+ Hits 751 774 +23
- Misses 669 779 +110
Partials 56 56 ☔ View full report in Codecov by Sentry. |
63755c2
to
c47a003
Compare
I am going to rework hsi and htar to work within classes instead of standalone functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a set of functions to enable interfacing with hsi and htar within Python.
Partly resolves #2.
Type of change
How Has This Been Tested?
New tests cannot be added at this time, but will be soon.
In the meantime, tests were written manually for each new function and tested locally.
Checklist