Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hsi #21

Closed
wants to merge 13 commits into from
Closed

Conversation

DavidHuber-NOAA
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA commented Apr 2, 2024

Description

Create a set of functions to enable interfacing with hsi and htar within Python.

Partly resolves #2.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • pynorms
  • pytests
    New tests cannot be added at this time, but will be soon.
    In the meantime, tests were written manually for each new function and tested locally.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 48.10%. Comparing base (81bfec0) to head (c47a003).

Files Patch % Lines
src/wxflow/hsi.py 12.50% 77 Missing ⚠️
src/wxflow/htar.py 24.24% 25 Missing ⚠️
src/wxflow/fsutils.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #21      +/-   ##
===========================================
- Coverage    50.88%   48.10%   -2.78%     
===========================================
  Files           16       18       +2     
  Lines         1476     1609     +133     
  Branches       313      336      +23     
===========================================
+ Hits           751      774      +23     
- Misses         669      779     +110     
  Partials        56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidHuber-NOAA
Copy link
Collaborator Author

I am going to rework hsi and htar to work within classes instead of standalone functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HPSS support
1 participant