Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete reduction method time average #1307

Closed
Closed
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
424e7ec
Updates reduction method min/max
ganganoaa Jul 18, 2023
e2b58e0
Updates Makefile.am, fms_diag_axis_object.F90, and fms_diag_reduction…
ganganoaa Jul 18, 2023
dd496af
Removed a data assignment statement before variable declarations in t…
ganganoaa Jul 18, 2023
a314839
Updates fms_diag_file_object_mod and fms_diag_object_mod
ganganoaa Jul 18, 2023
b3b0e3c
Updates fms_diag_bbox_mod and fms_diag_object_mod
ganganoaa Jul 18, 2023
773aca2
Updates Makefile.am and fms_diag_object_mod
ganganoaa Jul 18, 2023
0207a98
Updates Makefile.am
ganganoaa Jul 18, 2023
ffec2be
Updates fms_diag_reduction_methods_mod
ganganoaa Jul 18, 2023
0f79a5b
Updates fms_diag_object_mod and fms_diag_reduction_methods_mod
ganganoaa Jul 18, 2023
a996ce2
Updates fms_diag_reduction_methods_mod
ganganoaa Jul 18, 2023
24d664a
Updates fms_diag_object.F90
ganganoaa Jul 18, 2023
8cbab45
Update fms_diag_object.F90 and fms_diag_reduction_methods.F90
ganganoaa Jul 18, 2023
ab9c56f
Updates fms_diag_update_extremum_mod
ganganoaa Jul 19, 2023
24c6251
Updates fms_diag_update_extremum_mod
ganganoaa Jul 19, 2023
d74666c
Updates fms_diag_update_extremum_mod
ganganoaa Jul 19, 2023
158055e
Updates fms_diag_update_extremum_mod
ganganoaa Jul 19, 2023
345f2f9
Updates Makefile.am in diag_manager
ganganoaa Jul 19, 2023
aeb95fe
Updates CMakeLists.txt, diag_manager/Makefile.am, fms_diag_object.F90…
ganganoaa Jul 19, 2023
2be3a65
Updates error strings in fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
6f89cf1
Update fms_diag_object.F90 and fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
2721805
Updates fms_diag_object.F90
ganganoaa Jul 19, 2023
a115651
Updates fms_diag_object.F90 and fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
da59105
Updates fms_diag_object.F90 and fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
8c14131
Updates fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
823a25c
Updates fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
a473284
Updates fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
5e029ab
Updates fms_diag_reduction_methods.F90
ganganoaa Jul 19, 2023
4fe328f
Fixes mismatch argument type(weight) in routine fms_diag_do_reduction
ganganoaa Jul 19, 2023
9c024f8
Updates fms_diag_object_mod
ganganoaa Jul 19, 2023
d6f242d
Updates fms_diag_object_mod
ganganoaa Jul 19, 2023
0e55996
Updates fms_diag_reduction_methods_mod
ganganoaa Jul 20, 2023
4e69ad7
Fixes mismatch rank of an argument passed to routine fms_diag_update_…
ganganoaa Jul 20, 2023
7a63654
Declares oor_mask as contiguous target in routine fms_diag_do_reduction
ganganoaa Jul 20, 2023
2b47d80
Updates fms_diag_object.F90 and fms_diag_reduction_methods.F90
ganganoaa Jul 20, 2023
b5454c4
Comments out allocate_diag_field_output_buffers and fms_diag_do_reduc…
ganganoaa Jul 20, 2023
77a66c5
Update fms_diag_reduction_methods.F90
ganganoaa Jul 21, 2023
693c529
refactor: `monin_obukhov_stable_mix` calls from `stable_mix_1d` (#1268)
J-Lentz Jul 13, 2023
009be59
fix: out-of-bounds memory access in axis_utils2 (#1157)
J-Lentz Jul 13, 2023
a2f3097
fix: maximize system stacksize limit in fms_init (#1233)
J-Lentz Jul 13, 2023
e13e83f
test: remove stack limit checks in test scripts (#1280)
rem1776 Jul 13, 2023
340fce3
fix: mpp global arrays test fixes (#1174)
rem1776 Jul 13, 2023
59df93a
feat: update mpp_do_update_ad.fh to resolve JEDI requirement (#1225)
jkbk2004 Jul 13, 2023
78671e5
chore: add prefixed aliases for libfms routines (#1262)
rem1776 Jul 13, 2023
4a5ad15
Update fms_diag_reduction_methods.F90
ganganoaa Jul 24, 2023
731486b
Update fms_diag_bbox.F90
ganganoaa Jul 24, 2023
151c992
Update fms_diag_reduction_methods.F90
ganganoaa Jul 24, 2023
2a7e54c
Update fms_diag_reduction_methods.F90
ganganoaa Jul 24, 2023
96287fd
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
d200e1c
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
de75dad
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
2a55ad9
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
7361947
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
cd7beeb
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
10f0891
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
840c3c3
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
4cdff6d
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
ddaec5f
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
f7f4a40
Update fms_diag_object.F90
ganganoaa Jul 25, 2023
fd3b88f
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
0825006
Update fms_diag_reduction_methods.F90
ganganoaa Jul 25, 2023
5d8a4ce
Incomplete time average reduction for future updates
ganganoaa Jul 27, 2023
7470f06
Merge remote-tracking branch 'upstream/dmUpdate' into reduction_avera…
Aug 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updates CMakeLists.txt, diag_manager/Makefile.am, fms_diag_object.F90…
…, fms_diag_reduction_methods.F90
ganganoaa committed Jul 19, 2023
commit aeb95fec16511c583d2b82319f2937e8dc64e713
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -139,6 +139,7 @@ list(APPEND fms_fortran_src_files
diag_manager/fms_diag_elem_weight_procs.F90
diag_manager/fms_diag_fieldbuff_update.F90
diag_manager/fms_diag_bbox.F90
diag_manager/fms_diag_reduction_methods.F90
drifters/cloud_interpolator.F90
drifters/drifters.F90
drifters/drifters_comm.F90
3 changes: 2 additions & 1 deletion diag_manager/Makefile.am
Original file line number Diff line number Diff line change
@@ -90,7 +90,8 @@ diag_manager_mod.$(FC_MODEXT): diag_axis_mod.$(FC_MODEXT) diag_data_mod.$(FC_MOD
fms_diag_time_reduction_mod.$(FC_MODEXT) fms_diag_outfield_mod.$(FC_MODEXT) \
fms_diag_fieldbuff_update_mod.$(FC_MODEXT)
fms_diag_output_buffer_mod.$(FC_MODEXT): diag_data_mod.$(FC_MODEXT)
fms_diag_reduction_methods_mod.$(FC_MODEXT): diag_util_mod.$(FC_MODEXT)
fms_diag_reduction_methods_mod.$(FC_MODEXT): fms_diag_bbox_mod.$(FC_MODEXT) fms_diag_output_buffer_mod.$(FC_MODEXT) \
diag_data_mod.$(FC_MODEXT)

# Mod files are built and then installed as headers.
MODFILES = \
12 changes: 8 additions & 4 deletions diag_manager/fms_diag_object.F90
Original file line number Diff line number Diff line change
@@ -530,9 +530,6 @@ logical function fms_diag_accept_data (this, diag_field_id, field_data, time, is
return
end if

!> Allocate buffers of this field variable
call allocate_diag_field_output_buffers(field_data, diag_field_id)

!> Does the user want to push off calculations until send_diag_complete?
buffer_the_data = .false.
!> initialize the number of threads and level to be 0
@@ -569,7 +566,10 @@ logical function fms_diag_accept_data (this, diag_field_id, field_data, time, is
fms_diag_accept_data = .TRUE.
return
else
!!TODO: Loop through fields and do averages/math functions
!> Allocate buffers of this field variable
call allocate_diag_field_output_buffers(field_data, diag_field_id)

!> Do time reductions (average, min, max, rms error, sum, etc.)
fms_diag_accept_data = fms_diag_do_reduction(field_data, diag_field_id, oor_mask, weight, &
time, is_in, js_in, ks_in, ie_in, je_in, ke_in, err_msg)
call this%FMS_diag_fields(diag_field_id)%set_math_needs_to_be_done(.FALSE.)
@@ -1185,6 +1185,7 @@ function fms_diag_do_reduction(this, field_data, diag_field_id, oor_mask, weight
reduction_method = this%FMS_diag_fields(diag_field_id)%diag_field(i)%get_var_reduction()
has_diurnal_axis = this%FMS_diag_fields(diag_field_id)%diag_field(i)%has_n_diurnal()
field_name = this%FMS_diag_fields(diag_field_id)%diag_field(i)%get_var_fname()
reduced_k_range = this%FMS_diag_fields(diag_field_id)%diag_field(i)%has_var_zbounds()

if (this%FMS_diag_fields(diag_field_id)%diag_field(i)%has_pow_value()) THEN
pow_val = this%FMS_diag_fields(diag_field_id)%diag_field(i)%get_pow_value()
@@ -1215,6 +1216,9 @@ function fms_diag_do_reduction(this, field_data, diag_field_id, oor_mask, weight
type is (fmsDiagSubAxis_type)
l_start(j) = ptr_axis%get_starting_index()
l_end(j) = ptr_axis%get_ending_index()
type is (fmsDiagFullAxis_type)
l_start(j) = 1
l_end(j) = ptr_axis%axis_length()
class default
call mpp_error(FATAL, 'fms_diag_object_mod::fms_diag_do_reduction non fmsDiagSubAxis_type axis')
end select
2 changes: 1 addition & 1 deletion diag_manager/fms_diag_reduction_methods.F90
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ module fms_diag_reduction_methods_mod
use fms_mod, only: fms_error_handler
use fms_diag_bbox_mod
use fms_diag_output_buffer_mod
use diag_util_mod, only: debug_diag_manager
use diag_data_mod, only: debug_diag_manager

implicit none
private