Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes variables named data to other variable names #1355

Merged
merged 65 commits into from
Nov 14, 2023

Conversation

mcallic2
Copy link
Contributor

Description
data was introduced as a "data statement" in fortran 77. It can be used to declare/assign values to variables.
In FMS, the instance of data being used as a variable name happens often. This PR suggests changes to these variable names, and does not include any directories/modules that are either no longer used and/or deprecated (i.e. axis_utils, mpp_io, fms_io, etc).

Fixes # 1328

How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

mcallic2 and others added 30 commits August 9, 2023 15:07
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make surew we do exhaustive testing since there are significant modifications to the mpp layer (domains).

@rem1776
Copy link
Contributor

rem1776 commented Nov 9, 2023

@thomas-robinson This needs a third review from you before it can go in

@rem1776 rem1776 merged commit be1856c into NOAA-GFDL:main Nov 14, 2023
@rem1776 rem1776 mentioned this pull request Nov 20, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants