add time sum reduction to dmUpdate #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
approved these changes
Sep 27, 2023
Comment on lines
244
to
258
| do k = 0, ke_out - ks_out | ||
| do j = 0, je_out - js_out | ||
| do i = 0, ie_out - is_out | ||
| if (mask(is_in + i, js_in + j, ks_in + k, l + 1)) then | ||
| data_out(is_out + i, js_out + j, ks_out + k, l + 1, 1) = & | ||
| data_out(is_out + i, js_out + j, ks_out + k, l + 1, 1) & | ||
| + data_in(is_in +i, js_in + j, ks_in + k, l + 1) | ||
| else | ||
| data_out(is_out + i, js_out + j, ks_out + k, l + 1, 1) = missing_value | ||
| endif | ||
| enddo | ||
| enddo | ||
| enddo | ||
| enddo |
There was a problem hiding this comment.
Can this be reduced to a where and elsewhere constuct?
There was a problem hiding this comment.
Yeah that works, added in 618bb06
thomas-robinson
approved these changes
Oct 11, 2023
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds time_sum reduction method and adds a test based off the other time_* reduction tests.
I think the numbers from the added check test make sense, but let me know if you see any issues. I put some comments so its easier to tell what the results end up as.
How Has This Been Tested?
Tested on amd with oneapi 2023.2
Checklist:
make distcheckpasses