Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bennett & Uriel data_override mini assignment for YAML and data tables #1382

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

bcc2761
Copy link
Contributor

@bcc2761 bcc2761 commented Oct 3, 2023

Description
Following Uriel's instructions and guidance, made changes to:

  • data_override/include/data_override.inc
  • test_fms/data_override/test_data_override2.sh
  • test_fms/field_manager/test_field_manager2.sh

as well as creating

  • test_fms/data_override/test_data_override_init.F90

Fixes # (issue)
Added a namelist named use_data_table_yaml to have default option for user

How Has This Been Tested?
Tests labeled in test_fms/data_override/test_data_override2.sh, including:

  1. data_override with the default table (i.e not setting the namelist created)
  2. data_override with the yaml table (i.e setting the namelist created to .True.)
  3. data_override with the default table (i.e setting the namelist created to .True.)

To compile & run (lscamd50-d) inside FMS/build/:

  • autoreconf -if ../configure.ac
  • module load oneapi mpi compiler hdf5 netcdf libyaml
  • set CC=mpiicc
  • ../configure --with-yaml FC=which mpiifort CC=which mpiicc CPPFLAGS="nc-config --cflags nf-config --fflags -I/opt/libyaml/0.2.5/ONEAPI/2022.2/include -g -traceback" LDFLAGS="-L/opt/libyaml/0.2.5/ONEAPI/2022.2/lib" LIBS="nc-config --libs nf-config --flibs"
  • make check

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707
Copy link
Contributor

you forgot to git add the test_data_override_init.F90 that you created

@rem1776 rem1776 merged commit b0dbc30 into NOAA-GFDL:main Nov 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants