-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bennett & Uriel data_override mini assignment for YAML and data tables #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressed naming issues with 'use_yaml' and 'use_data_table_yaml'
bcc2761
requested review from
rem1776,
bensonr and
thomas-robinson
as code owners
October 3, 2023 18:15
you forgot to |
rem1776
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following Uriel's instructions and guidance, made changes to:
as well as creating
Fixes # (issue)
Added a namelist named use_data_table_yaml to have default option for user
How Has This Been Tested?
Tests labeled in test_fms/data_override/test_data_override2.sh, including:
To compile & run (lscamd50-d) inside FMS/build/:
which mpiifort
CC=which mpiicc
CPPFLAGS="nc-config --cflags
nf-config --fflags
-I/opt/libyaml/0.2.5/ONEAPI/2022.2/include -g -traceback" LDFLAGS="-L/opt/libyaml/0.2.5/ONEAPI/2022.2/lib" LIBS="nc-config --libs
nf-config --flibs
"Checklist:
make distcheck
passes