Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed mode updates for beta1 #1384

Merged
merged 72 commits into from
Oct 6, 2023
Merged

Mixed mode updates for beta1 #1384

merged 72 commits into from
Oct 6, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Oct 4, 2023

Description
Merges in the latest batch of mixed precision updates, includes:

  • amip_interp
  • column_diagnostics
  • mosiac/mosaic2
  • tridiagonal

Also adds unit tests for the existing updates to coupler and topography

How Has This Been Tested?
amd box with latest oneapi

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

rem1776 and others added 30 commits November 23, 2022 15:03
Revert "feat: emc mixedmode support (NOAA-GFDL#997)"
a22e194 
This reverts commit 8a4ad84.
Add back in constants4 files from emc revert
95287f5
@mlee03
chore: add include files for easier reviews (NOAA-GFDL#1086)
61ac8a9
Merge remote-tracking branch 'origin/main' into mixedmode
38b5143
Merge remote-tracking branch 'origin/main' into mixedmode
4dbd23c
@rem1776
chore: copy over changes from modules to includes (NOAA-GFDL#1115)
fcaca04
@mlee03
fix: add class(*) back to diag_manager (NOAA-GFDL#1123)
2456a41 
Co-authored-by: mlee03 <[email protected]>
@mlee03
Update mixedmode to main (NOAA-GFDL#1143)
17a5359
@mlee03
update the mixedmode branch to main (NOAA-GFDL#1153)
24760ee
@mlee03
update mixedmode to main (NOAA-GFDL#1171)
8376481
@mcallic2
feat: mixed precision axis_utils2 (NOAA-GFDL#1104)
2edc3dc
@J-Lentz
feat: mixed precision fms_mod (NOAA-GFDL#1147)
6b3855a
@rem1776
feat: horiz interp mixed precision (NOAA-GFDL#1067)
cdabf07
@mlee03
mixed precision sat_vapor_pressure (NOAA-GFDL#1095)
7b3906c
@J-Lentz
feat: add mixed precision axis_utils unit tests (NOAA-GFDL#1172)
f1adb5e
@rem1776
merge _base into mixedmode branch (NOAA-GFDL#1180)
e6c6e38
@rem1776
fix: move type definitions to before first usage to fix nvhpc bug (NO…
66c1297 
…AA-GFDL#1187)
@rem1776
fix: change allocatable type for intel errors (NOAA-GFDL#1221)
be8473d
@J-Lentz
feat: eliminate use of real numbers for mixed precision in `block_con…
b3aca89 
…trol` (NOAA-GFDL#1195)
@rem1776
chore: merge mixedmode_base into mixedmode (NOAA-GFDL#1235)
4cb3f69
@mlee03
fix: private routines in libFMS.F90 (NOAA-GFDL#1241)
d5980a8
@mlee03
feat: mixed precision field_manager (NOAA-GFDL#1205)
c036f90
@J-Lentz
feat: mixed precision random_numbers_mod (NOAA-GFDL#1191)
9f3c791
@rem1776
feat: mixed precision time_manager reals to r8 and clean up (NOAA-GFD…
f655759 
…L#1196)
@mlee03
feat: mixed Precision tracer_manager (NOAA-GFDL#1212)
9340a5d
fix duplicate test directory from merge
ba97253
@mlee03
chore: Update mixedmode (NOAA-GFDL#1304)
d2733bb
@mcallic2
Mixed precision monin_obukhov (NOAA-GFDL#1116)
7f8abc2
@J-Lentz
Mixed precision: monin_obukhov unit tests (NOAA-GFDL#1272)
f7b7544
@mlee03
mixed-precision diag_integral_mod (NOAA-GFDL#1217)
0e0956c
rem1776 and others added 13 commits September 19, 2023 11:13
fix comments in gaussian_topog.F90
98d5ee3
@rem1776
Merge pull request #92 from mlee03/mixedmode-alpha3-mlee03
aa84fd7 
add rm diag_integral.out to test script
fix types used in get_calendar_time
70a2be8
delete out file appropriately
7583db7
@rem1776
Merge pull request #93 from mlee03/mixedmode-alpha3-mlee03
1485874
@mcallic2
mixed precision topography unit tests (NOAA-GFDL#1364)
c0c193f
@rem1776
mixed precision tridiagonal (NOAA-GFDL#1363)
acc1368
@rem1776
mixed precision: add test for coupler_types and data_override changes (…
ea79688 
…NOAA-GFDL#1361)
@J-Lentz
Mixed precision amip_interp_mod (NOAA-GFDL#1365)
0f3d5e9 
BREAKING CHANGE: Several variables and arrays which were previously public have been made private.
These variables and arrays are not used in ice_amip or ocean_amip.
amip_interp_type(r4_kind) and amip_interp_type(r8_kind) should be used for
r4_kind and r8_kind precision, respectively. amip_interp_type without a kind
parameter defaults to r8_kind.
Merge remote-tracking branch 'upstream/mixedmode' into mixedmode_alpha3
d7ee155
Merge branch 'mixedmode_alpha3' of github.com:rem1776/FMS into mixedm…
069934f 
…ode_alpha3
Merge remote-tracking branch 'upstream/main' into mixedmode_alpha3
b31acd9
fix eol and add tridiag include dir to cmake
ac6f9af
@rem1776 rem1776 requested review from J-Lentz, mlee03 and mcallic2 October 4, 2023 18:54
thomas-robinson
thomas-robinson previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trusting the team did a good/thorough review here

bensonr
bensonr reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mosaic deprecated in favor of mosaic2? If so, I find it confusing that we have a test_fms/mosaic directory, but it contains tests for mosaic2. I think it should be renamed to test_fms/mosaic2

@mlee03
Copy link
Contributor

mlee03 commented Oct 6, 2023

@rem1776 PR to your branch with mosaic changes coming soon

@rem1776 rem1776 merged commit 11be274 into NOAA-GFDL:main Oct 6, 2023
17 of 19 checks passed
bensonr
bensonr approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will FMS/mosaic be going away at some point?

@mlee03
Copy link
Contributor

mlee03 commented Oct 6, 2023

@bensonr it will with mosaic cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-robinson thomas-robinson thomas-robinson approved these changes

@bensonr bensonr bensonr approved these changes

@J-Lentz J-Lentz Awaiting requested review from J-Lentz

@mlee03 mlee03 Awaiting requested review from mlee03

@mcallic2 mcallic2 Awaiting requested review from mcallic2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rem1776 @mlee03 @bensonr @thomas-robinson @mcallic2 @J-Lentz