Support monotonically increasing/decreasing array in data_override #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
bensonr
reviewed
Oct 11, 2023
bensonr
previously approved these changes
Oct 17, 2023
uramirez8707
changed the title
uramirez8707
changed the title
bensonr
previously approved these changes
Oct 25, 2023
| @@ -265,7 +270,7 @@ | |||
| !! inputs: | |||
| !! | |||
| !! rval = arbitrary data...same units as elements in "array" | |||
| !! array = array of data points (must be monotonically increasing) | |||
| !! array = array of data points (must be monotonically) | |||
There was a problem hiding this comment.
This is an incomplete sentence. Can you fix for the beta tag?
Comment on lines
+1034
to
+1041
| ! do j = 1, axis_sizes(2)+1 | ||
| ! if( override_array(curr_position)%lat_in(j) > lat_min ) exit | ||
| ! js_src = j | ||
| ! enddo | ||
| ! do j = 1, axis_sizes(2)+1 | ||
| ! je_src = j | ||
| ! if( override_array(curr_position)%lat_in(j) > lat_max ) exit | ||
| ! enddo |
thomas-robinson
approved these changes
Dec 14, 2023
rem1776
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nearest_indexto support monotonically increasing/decreasing arraysaxis_edgesto support monotonically increasing/decreasing arraysFixes #1387
Fixes #1397
Fixes #1213
How Has This Been Tested?
CI, including tests that were added
Checklist:
make distcheckpasses