Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt - append extra flags for gnu 10+ with mpich #1418

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

climbfuji
Copy link
Contributor

@climbfuji climbfuji commented Nov 22, 2023

Description
This PR fixes #1417. Instead of overwriting the compile flags for the Fortran targets, it appends the compatibility flags for gnu 10 with mpich to the existing flags. The syntax I used is available since cmake 2.8.12.

Resolves #1417

How Has This Been Tested?
Tested on Derecho with [email protected] and [email protected].

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes (not run)

@thomas-robinson
Copy link
Member

@climbfuji do you need a patch for 2023.03?

@climbfuji
Copy link
Contributor Author

climbfuji commented Nov 22, 2023 via email

@thomas-robinson
Copy link
Member

2023.04 is mostly supporting a coupler update and updating variable names to no longer be Fortran keywords. It should be an easy update from 2023.03.

@climbfuji
Copy link
Contributor Author

In that case I think we don't need a bug fix release for 2023.03 - thanks!

@rem1776 rem1776 merged commit 8287203 into NOAA-GFDL:main Nov 27, 2023
19 checks passed
@climbfuji climbfuji deleted the patch-1 branch November 27, 2023 14:36
@climbfuji
Copy link
Contributor Author

Thanks very much @rem1776! Will this be included in [email protected]?

@rem1776
Copy link
Contributor

rem1776 commented Nov 27, 2023

Yes this will be in 2023.04. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler error fms 2023.03 with gnu 12.2.0 (coupler_types.F90 - fms_io_register_restart_field)
3 participants