Improve the performance in nearest_index #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
requested review from
thomas-robinson,
bensonr and
rem1776
as code owners
rem1776
previously approved these changes
Jan 18, 2024
bensonr
reviewed
Jan 19, 2024
axis_utils/include/axis_utils2.inc
Outdated
| NEAREST_INDEX_ = 1 | ||
| return | ||
| elseif (rval > array(ia)) then | ||
| elseif (rval .gt. array(ia)) then |
There was a problem hiding this comment.
Same comment with > going to .gt. as above.
axis_utils/include/axis_utils2.inc
Outdated
Comment on lines
342
to
347
| DO i = 1, ia | ||
| if (rval .le. array(i)) then | ||
| NEAREST_INDEX_ = i | ||
| if (array(i) -rval .gt. rval - array(i-1)) NEAREST_INDEX_ = i - 1 | ||
| return | ||
| endif |
There was a problem hiding this comment.
Do you need to make a similar change in the decreasing block?
|
@bensonr I think i addressed your comments. Let me know if the logic doesn't seem correct. |
bensonr
reviewed
Jan 19, 2024
rem1776
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves performance of
nearest_indexFixes #1444
How Has This Been Tested?
CI
Checklist:
make distcheckpasses