Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml parser error checking #1563

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

uramirez8707
Copy link
Contributor

Description
Check error code in the parser to prevent the code to hang when using an invalid yaml
Add tests with an invalid yaml

Fixes #1562

How Has This Been Tested?
CI, including new test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

rem1776
rem1776 previously approved these changes Aug 1, 2024
@rem1776
Copy link
Contributor

rem1776 commented Aug 1, 2024

@uramirez8707 I think you just need to adjust the test numbers in this line to pass the CI, its just not skipping the parser tests when not compiled with yaml.

SKIP_TESTS='test_yaml_parser.[1-23]'

bensonr
bensonr previously approved these changes Aug 1, 2024
@uramirez8707 uramirez8707 dismissed stale reviews from bensonr and rem1776 via ce47c29 August 1, 2024 14:59
@uramirez8707
Copy link
Contributor Author

@uramirez8707 I think you just need to adjust the test numbers in this line to pass the CI, its just not skipping the parser tests when not compiled with yaml.

SKIP_TESTS='test_yaml_parser.[1-23]'

Thanks for pointing me to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser hangs if using an invalid yaml
3 participants