Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_center_grid_points namelist #1566

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

uramirez8707
Copy link
Contributor

Description
Adds a new namelist, use_center_grid_points, which indicates whether or not to use the centroid values of the supergrid from the grid file as opposed to calculating it by taking the average of the four corner points. This is only relevant to OCN and ICE grids.

The namelist is needed because answers will not bit for bit reproduce, but overall the answers should not be very different.

The namelist should be set to .True.

Fixes #1537

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rem1776 rem1776 merged commit 7cc9803 into NOAA-GFDL:main Aug 2, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data_override:: Issue with reading the grid file in data_override when using 0:180:-180:0 grids
3 participants