Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demonstration of first stage of bats removal... #222

Closed

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Nov 26, 2019

In this PR I demonstrate how shell scripts may be used instead of bats, selectable by configure.

The configure option --enable-shell-tests will cause the tests in test_fms/axis_utils to run from a shell script, not a bats script. Running without --enable-shell-tests will cause bats to be used as usual.

The intention is to move all testing to shell scripts. Once all are satisfied that all tests have been moved, we can then remove bats, and remove the --enable-shell-tests option.

This PR includes my other outstanding PRs, to get through my own FMS CI system.

@edwardhartnett
Copy link
Contributor Author

OK, this shows the first stage of bats removal for axis_utils and diag_manager test directories.

Existing bats-running shell scripts must be changed to *.test instead of *.sh because of automake LOG_DRIVER restrictions, they must have different file extensions than the new shell tests.

Take a look and if this looks good I can quickly apply this to the other directories and then bats can be removed.

@edwardhartnett
Copy link
Contributor Author

OK, now this PR is complete. All tests run under bats can now be run by shell scripts instead with --enable-shell-tests at configure.

Next step is to remove the bats stuff. I will do that in a separate PR.

@edwardhartnett
Copy link
Contributor Author

This should not be merged, instead merge #228
This remains open for ease of inspection.

@edwardhartnett edwardhartnett deleted the ejh_remove_bats_1 branch June 11, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants