Nest updates for FMS #227
Merged
Nest updates for FMS #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arse_update branch
…r the infamous 'compute_qs' crash
…to lmh_ncep_regional
…c-output-fails-to-write-history-file' into user/lmh/fvGFS
…to user/lmh/fvGFS
underwoo
added
the
enhancement
|
It looks like this is failing travis due to make distcheck, because the input.nml files are not being correctly copied to the build directories. For example, from test_fms/axis_util/test_axis_utils.sh:
This kind of copy is necessary for all data files needed in tests. When the changes in this PR are merged, they are going to impact the bats removal PR and other open PRs. |
|
@bensonr and @wrongkindofdoctor, once the PR #228 is merged let's see if that resolves the build issues with this PR. If not, I will look to see what needs to be updated. |
|
I looked at the output from travis the day I put in the PR and it would
have failed regardless of whether input.nml was being copied correctly or
not by the script. I forgot to update input_base.nml to account for
changes in test_mpp_domains.F90.
…On Fri, Nov 29, 2019 at 6:31 PM Seth Underwood ***@***.***> wrote:
@bensonr <https://github.com/bensonr> and @wrongkindofdoctor
<https://github.com/wrongkindofdoctor>, once the PR #228
<#228> is merged let's see if that
resolves the build issues with this PR. If not, I will look to see what
needs to be updated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#227?email_source=notifications&email_token=ABSKBVDT7Q27MUULM46HINDQWGQ5JA5CNFSM4JSKRI2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPVCMQ#issuecomment-559894834>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSKBVDUEEKHYJTEICFAQVDQWGQ5JANCNFSM4JSKRI2A>
.
|
colingladueNOAA
previously approved these changes
Mar 17, 2020
bensonr
dismissed stale reviews from colingladueNOAA, thomas-robinson, and underwoo
via
2f4e853
underwoo
previously approved these changes
Mar 17, 2020
|
@colingladueNOAA once the last approvals are done, this PR can be done. |
menzel-gfdl
previously approved these changes
Mar 17, 2020
GFDL-Eric
previously approved these changes
Mar 17, 2020
thomas-robinson
previously approved these changes
Mar 18, 2020
colingladueNOAA
previously approved these changes
Mar 19, 2020
bensonr
dismissed stale reviews from colingladueNOAA, thomas-robinson, GFDL-Eric, menzel-gfdl, and underwoo
via
cc2e624
underwoo
approved these changes
Mar 20, 2020
|
@colingladueNOAA @thomas-robinson @wrongkindofdoctor please review and approve. This is just an update, merging master back into the branch for this PR. |
colingladueNOAA
approved these changes
Mar 20, 2020
wrongkindofdoctor
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feature request #226
Code has been tested for reproducibility after proper updates within SHiELD and GFDL AM4/CM4 models. Full testing will need to be performed once updates are merged.