Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/TUTT_Diag #250

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

jiacheng-atmos
Copy link
Contributor

@jiacheng-atmos jiacheng-atmos commented Jul 3, 2021

Description
A new POD - Tropical Upper-Troposheric Trough (TUTT) Diag is introduced. This is a preliminary version that may need further changes.

Associated issue # (replace this phrase and parentheses with the issue number)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes in enough detail that
someone can reproduce them. Include any relevant details for your test configuration
such as the Python version, package versions, expected POD wallclock time, and the
operating system(s) you ran your tests on.

Checklist:

  • I have reviewed my own code to ensure that if follows the POD development guidelines
  • My branch is up-to-date with the NOAA-GFDL develop branch, and all merge conflicts are resolved
  • The script are written in Python 3.6 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • If applicable, I've added a .yml file to src/conda, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • The repository contains no extra test scripts or data files

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 12, 2021

This pull request introduces 10 alerts when merging 5e66b15 into 473e0e8 - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Redundant assignment

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 12, 2021

This pull request introduces 10 alerts when merging 87e0742 into 473e0e8 - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Redundant assignment

@wrongkindofdoctor wrongkindofdoctor removed the request for review from tsjackson-noaa October 4, 2021 15:16
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 7, 2022

This pull request introduces 10 alerts when merging 53285a7 into 748d6da - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Redundant assignment

deleted a comma
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 21, 2022

This pull request introduces 10 alerts when merging 20af841 into 748d6da - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Redundant assignment

@wrongkindofdoctor wrongkindofdoctor changed the base branch from develop to main June 17, 2022 14:19
@wrongkindofdoctor
Copy link
Collaborator

@jiacheng-atmos It's been a while since we touched base, so let me know what the status of the POD is when you are able. Note that I changed the target branch to "main" so that the framework team can eventually delete the develop branch. All merges/rebases should be pulled from main from this point forward. Let me know if you have issues.

@wrongkindofdoctor wrongkindofdoctor mentioned this pull request Jun 17, 2022
16 tasks
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 17, 2022

This pull request introduces 10 alerts when merging 20af841 into a6e5f11 - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Redundant assignment

@jiacheng-atmos
Copy link
Contributor Author

@jiacheng-atmos It's been a while since we touched base, so let me know what the status of the POD is when you are able. Note that I changed the target branch to "main" so that the framework team can eventually delete the develop branch. All merges/rebases should be pulled from main from this point forward. Let me know if you have issues.

Thank you for your information. I will try to fix the problem you pointed out earlier this weekend. Do you mean that I should work with the main branch instead of the develop branch by then?

@wrongkindofdoctor
Copy link
Collaborator

@jiacheng-atmos Yes, you should merge updates from the main branch, not the develop branch, into your POD branch as needed. The remote TUTT branch's upstream is now the NOAA-GFDL/main branch (you can verify this in the web interface by navigating to the TUTT branch on your fork, and clicking the "fetch upstream" button).

@jiacheng-atmos
Copy link
Contributor Author

@jiacheng-atmos Yes, you should merge updates from the main branch, not the develop branch, into your POD branch as needed. The remote TUTT branch's upstream is now the NOAA-GFDL/main branch (you can verify this in the web interface by navigating to the TUTT branch on your fork, and clicking the "fetch upstream" button).

Thanks so much for your answer. I will fix the problems this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic Issue pertains to a contributed diagnostic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants