Iceberg identifications #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… counts the amount of icebergs created by each cell. This has been added to the write restart. I tried to add it to read restart, but it is not working yet. (And now its time for the weekend)
…erg_num and is saved in the restart file, picksup from the restart file. The iceberg counter is now working and is saved as a gridded variable which saves to the restart file, and picksup from the restart. The iceberg num is not yet saved in the iceberg trajectory file.
| @@ -2871,9 +2887,10 @@ integer function berg_chksum(berg ) | |||
| itmp(37)=berg%start_year !Changed from 29 to 37 by Alon | |||
| itmp(38)=berg%ine !Changed from 30 to 38 by Alon | |||
| itmp(39)=berg%jne !Changed from 31 to 39 by Alon | |||
| itmp(40)=berg%iceberg_num !added by Alon | |||
There was a problem hiding this comment.
itmp needs to be declared itmp(36+4) in order to avoid an out-of-bounds at this line.
|
Unfortunately I'm getting
which has nothing to do with your commits but is due to issue #7. We just started using a patched FMS for Ben's 4d restarts to work in MOM6 and this code doesn't have the fix that allows the iceberg restarts to work. I'll ask to have this sorted out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a number scheme so that each iceberg gets a unique number. The number is based on a counter which counts how many icebergs have been created in a particular grid cell.
The iceberg number is called iceberg_num, and is written to the iceberg_trajectory file, to be used in post processing. It is also written and read from the iceberg.res restart file.
The iceberg grd counter is called iceberg_counter_grd. It is written and read from the calving.res restart file (since it is gridded).
The previous method used for identifying icebergs (ie: start_year, start_mass, start_lon, start_lat, start_day) has been left in place, and is still being used in several places to sort icebergs. This can be removed and replaced by the counter system at a later time.